This one has been bugging me for a while now. On the HTML help page (filter.module) the <h[1-6]> tags are labeled "header" when in fact what they are is headings, if I'm not completely off.

This wouldn't be such a big deal if this page was only viewed in English since the words are so similar. However – with translations into other languages things get worse. In Swedish, for example, the two words are "rubrik" and "sidhuvud". So you can imagine the confusion that arises when we translate this string into "rubrik" – which is correct in this context – and then suddenly "sidhuvud" becomes "rubrik" in all the rest of the interface. (Well, I might be creating some extra confusion for any non-Swedes right now, but you get the idea.)

Please, someone who speaks English natively, take a look at this patch.

CommentFileSizeAuthor
drupal_filter_heading_080501.patch1.98 KBzoo33

Comments

dries’s picture

dries commented

It would be great if an English speaking person could confirm this. :)

stevenpatz’s picture

stevenpatz
he/him
commented

They are in fact heading tags.
See: http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.5

stevenpatz’s picture

stevenpatz
he/him
commented
Status: Needs review » Reviewed & tested by the community
jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Needs review

They are in fact headings, not headers. See http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.5

That is, in the HTML sense they are headings. They wrap text which becomes a header for a section.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Yep, I think they're used fairly interchangeably in practice but doesn't hurt to get it right.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks all.

zoo33’s picture

zoo33 commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

Thanks for the quick action everyone!

Now, is there any chance this could go into D6?
I checked the .pot files and "Header" appears in one more location, so it doesn't need to be removed. "Heading" on the other hand doesn't exist yet so that would be a new string to translate.

Freso’s picture

Freso commented
Version: 6.x-dev » 7.x-dev
Status: Patch (to be ported) » Fixed

Drupal 6.x is in string freeze, so no strings are changing there (unless they're seriously/critically wrong, which I don't think this is).

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.