Call getBreakpointGroup() on a non-object in responsive_image.module

I cannot reproduce the error. Did you select a responsive image style for display?

Duplicate of #2489162: Can configure responsive image formatter to cause fatal error

I'm going to reopen this. 2489162 has the same symptoms but presumes user error. I encountered this after selecting a responsive image style, as @manishmore claims to have done as well. I was able to get it to stop by changing the selected responsive image style and saving the config again a few times. While it was occurring, $variables['responsive_image_style_id'] in template_preprocess_responsive_image was the empty string.

I was able to reproduce this error. Updated the issue summary with it.

Error does not happen again, when you don't select a responsive image style, the output is changed to a regular image. Was added as part of #2489162: Can configure responsive image formatter to cause fatal error, but I guess we need to log this as well, the same as template_preprocess_responsive_image is logging it.

Logger added

#9 is RTBC for me if/when the testbot comes back green.

This is a task now there is no bug and therefore is not eligible for inclusion in beta at this point.

It would be good to confirm that there are tests and add tests for the log message.

There is a test as part of #2489162: Can configure responsive image formatter to cause fatal error, but is it necessary to test the Logger?

Quoting myself from #15

but is it necessary to test the Logger?

If so we'll add a test

This still needs a test.

Also, I think at this point, this won't be committed to 8.0 anymore, since 8.0.6 was the final release.

Let's get this going again:

1. Check if patch applies.
2. If not, reroll.
3. If it applies, then work on adding a test for this. Check the related issue for an example.

I'm working on this.

The patch applied, and I was able generate the log message using the steps described in the issue description. Attached are screenshots of the log messages appearing. I'll start working on that test using the related issue as an example.

Testing a patch which tests that the first part of the log message exists on admin/reports/dblog.

I'm not sure how the patch fixes the Fatal in the IS but I can review the test.

+++ b/core/modules/responsive_image/src/Tests/ResponsiveImageFieldDisplayTest.php
@@ -214,6 +215,10 @@ protected function doTestResponsiveImageFieldFormatters($scheme, $empty_styles =
+    // The test field was not configured. This should be logged.
+    $this->drupalGet('admin/reports/dblog');
+    $this->assertText('No responsive image style defined');
+

Page fetches are pretty expensive and slow. You could just query the database.

alexpott in #14 mentioned we should test the log message exists.

We had a discussion and were wondering if it's necessary to test whether the log message exists after it is logged.

In SimpleTest we couldn't find a way to assert a log message exists in a reliable way.

Skimming some of the discussion it looks like the fatal was fixed elsewhere. We should probably update the Issue Summary so the commitor knows what's up.

For the test, something like this should work.

$this->assertNotEqual([], $this->getDatabaseConnection()
  ->query("SELECT wid FROM {watchdog} WHERE message = 'No responsive image style defined'")
  ->fetchAll());

// or
$results = $this->getDatabaseConnection()
  ->query("SELECT wid FROM {watchdog} WHERE message = 'No responsive image style defined'")
  ->fetchAll();
$this->assertTrue(count($results) > 0);

If you do that you can also drop the permission addition from the user create. From the failure it looks like it didn't work.

Following the steps in the IS I could not reproduce this. So it's either been fixed, or the IS needs an update at this point.

Since this was tagged for updated IS and steps 4 years ago going to close out for now.

If still a valid task though please reopen updating the issue summary.

Thanks all!