Closed (fixed)
Project:
Bootstrap
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Jul 2015 at 17:16 UTC
Updated:
8 Nov 2015 at 19:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pivica commentedHere is a patch.
Comment #2
markhalliwellI'm not entirely sure if the 8.x CDN provider are working properly. @neardark, please verify the parity of these branches.
@pivica:
FWIW.. if the issue is, in fact, the foreach loop then that is the area the patch should affect: the variable that the foreach loop uses should be changed, not the existing one that preceded it.
Comment #3
pivica commentedI am not using CDN providers so didn't check that part.
Yeah the foreach is a problem because it is overriding previous var. Here is a new patch that is renaming var in foreach. Also found one additional bug, on page settings form load this
$form_values = $form_state->getValues('cdn_provider');is returning empty array so next isset needs to be changed to !empty.
Comment #5
neardark commentedI've merged @pivica 's patch but could use someone to test. Also made a few other changes. Committed this before providing a patch -- sorry about that.
Comment #7
neardark commentedComment #8
polHi all,
The module Libraries API CDN is out today: https://www.drupal.org/project/libraries_cdn
It will probably help you to have a good integration in your theme.
Let me know if I can help.
Comment #9
markhalliwell@Pol, that looks like a cool module indeed. However, this project will likely never depend on an external module to provide integration/support in this manner. If we ever do add a module, it will be for internal purposes that only a module can hook into, like we have been doing with https://www.drupal.org/project/bootstrap_core
Comment #10
markhalliwellThis isn't needed on 7.x-3.x.