Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
user.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Jul 2015 at 19:11 UTC
Updated:
17 Aug 2015 at 18:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mikeryanA little trickier than the others thanks to the password service, but the patch is here. Postponed on #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.
Comment #2
phenaproximaUnblocked.
Comment #4
mikeryanUgh... Need to fix #2540594: MigratePassword service applied globally first.
Comment #5
mikeryanOK, the MigratePassword service wasn't as broken as I had thought at first, it just needed to implement getCountLog2() - I do think it's rather hacky and it's worth looking for a cleaner method, but it shouldn't hold up this patch.
Comment #6
phenaproximaThis guy is blocking #2534012: Move module-specific migration support into the file module.
Comment #7
phenaproximaWOW. That patch is like half of Migrate freakin' Drupal! Major kudos to @mikeryan for taking it on.
44.04 KB of very slow scrolling later, I think this looks pretty good. Git 'er done!
Comment #8
alexpottNeeds a reroll.
Comment #9
mikeryanComment #10
phenaproximaIt continues to please the eye and tickle the brain. (If by "tickle", you mean "smash with a sledgehammer".)
Comment #11
alexpottNeeds reroll.
Comment #12
mikeryanComment #13
phenaproxima@mikeryan says this was just a re-roll, and no functionality changed. If it passes the tests, I'm satisfied.
Comment #14
webchick@mikeryan and @phenaproxima walked me through this patch.
Even though this patch is quite large, the vast majority of this is just moving stuff around, so that's pretty straight-forward. A couple of weird things stuck out:
Question: Why are we not moving the user picture at the same time we're moving the rest of the User stuff? Answer: Because that entry is mis-labeled. It has nothing to do with user pictures, but is rather about file entities, so will be addressed in #2534012: Move module-specific migration support into the file module.
Uh... what the heck is this? :) Unlike other parts of this patch, this one has no corresponding - lines. Also, @inheritdoc is a misnomer; there's nothing in the parent class that defines this method; it actually happens in PhpassHashedPassword.
I asked for an updated comment here, and mikeryan posted:
I shortened this to:
...and fixed on commit.
Committed and pushed to 8.0.x. Onwards with the great migration migration! ;)
Comment #17
webchickYes, yes.