Moving the user migration support into the user module (#2534042: Move module-specific migration support into the user module) breaks UserLoginTest. This is because the default password service is replaced with the MigratePassword class, to handle old MD5 passwords by prepending 'U' to their hash. While this support was in the migrate_drupal module, it was not apparent because this would only happen when the migrate_drupal module is enabled, but of course if it's in the user class it's always taking place. We need to ensure that the effect only occurs within a user migration process, not globally on the site.

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Issue summary: View changes
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Category: Bug report » Task
Status: Active » Postponed

It wasn't that broken, just didn't implement getCountLog2(), so adding that enables #2534042: Move module-specific migration support into the user module to move forward. I do find the password service substitution a bit hacky, though - it may be worth looking for an alternative approach once the migration support moves to the user module.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Postponed » Active

user migration move complete, so we can think about a better way of doing this.

Jaesin’s picture

Jaesin commented

What do you think about creating a super light weight authentication provider module to handle this for drupal 6 users?

Jaesin’s picture

Jaesin commented

OK, Maybe that is a little heavy.

How about a separate module that will override @user.auth?

  user.auth:
    class: Drupal\user\UserAuth
    arguments: ['@entity.manager', '@drupal6_password']

If you have D6 passwords in your system as the result of a migration, you have need to have it enabled. Otherwise, there is no need.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Closed (outdated)

Fixed by #2598038: Invalid passwords after D7 to D8 migration removing the MigratePassword service entirely - nice!