Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for field migration into the field module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_field
  • d6_field_formatter_settings
  • d6_field_instance
  • d6_field_instance_widget_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#23 2534010-23.patch23.61 KBphenaproxima
#17 2534010-17.patch23.78 KBphenaproxima
#13 2534010-13.patch23.72 KBphenaproxima
#8 interdiff-2534010-5-8.txt524 bytesphenaproxima
#8 2534010-8.patch24.07 KBphenaproxima
#5 interdiff-2534010-2-5.txt13.11 KBphenaproxima
#5 2534010-5.patch24.01 KBphenaproxima
#2 2534010-2.patch13.36 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
2534010-2.patch13.36 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2534010-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2534010-5.patch24.01 KB
interdiff-2534010-2-5.txt13.11 KB

Moved the tests into the Drupal\field\Tests\Migrate namespace. Also moved the relevant process plugins into the Field module, and the source plugins' schema into field.schema.yml.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked.

Status: Needs review » Needs work

The last submitted patch, 5: 2534010-5.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2534010-8.patch24.07 KB
interdiff-2534010-5-8.txt524 bytes

If at first, yada yada.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented

After applying all the move patches, I see d6_cck_field_revision.yml and d6_cck_field_values.yml are still in migrate_drupal - is the thinking that they're intimately connected with the load plugin business that should be going away soon?

Thanks.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

After applying all the move patches, I see d6_cck_field_revision.yml and d6_cck_field_values.yml are still in migrate_drupal - is the thinking that they're intimately connected with the load plugin business that should be going away soon?

You grok it in fullness. These two are deprecated by the builder patch, and will be removed once it lands.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

Needs reroll

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2534010-13.patch23.72 KB

Status: Needs review » Needs work

The last submitted patch, 13: 2534010-13.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs work » Postponed
Related issues: +#2534022: Move module-specific migration support into the node module

This will need to go in after #2534022: Move module-specific migration support into the node module.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Postponed » Needs work

Unblocked by the node module commit - certainly will need a reroll.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2534010-17.patch23.78 KB

Re-rolled.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs review » Reviewed & tested by the community

This looks pretty kosher and straight forward. RTBC

Eclipse

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Reviewed & tested by the community » Postponed

This and the user patch make adjacent changes to the source schema, so the first one in will require the second to be rerolled. The user patch also blocks the file patch, so postponing this - user should go in next.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Postponed

Blocking again on #2534004: Move module-specific migration support into the comment module, since this one alters migrate_drupal.source.schema.yml as well.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Active
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
2534010-23.patch23.61 KB

Re-rolled.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Welcome back to RTBCville...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Moar moving.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 7bc3890 on 8.0.x 
    Issue #2534010 by phenaproxima, mikeryan: Move module-specific migration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.