Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for node migration into the node module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_node
  • d6_node_revision
  • d6_node_setting_promote
  • d6_node_setting_status
  • d6_node_setting_sticky
  • d6_node_settings
  • d6_node_type
  • d6_view_modes

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#19 interdiff-2534022-17-19.txt3.09 KBphenaproxima
#19 2534022-19.patch28.16 KBphenaproxima
#17 interdiff-2534022-15-17.txt389 bytesphenaproxima
#17 2534022-17.patch26.4 KBphenaproxima
#15 interdiff-2534022-13-15.txt744 bytesphenaproxima
#15 2534022-15.patch25.88 KBphenaproxima
#13 interdiff-2354022-8-13.txt802 bytesphenaproxima
#13 2534022-13.patch24.83 KBphenaproxima
#8 2534022-8.patch24.14 KBphenaproxima
#7 interdiff-2534022-6-7.txt1.05 KBphenaproxima
#7 2534022-7.patch24.14 KBphenaproxima
#6 interdiff-2534022-2-6.txt11.09 KBphenaproxima
#6 2534022-6.patch22.75 KBphenaproxima
#2 2534022-2.patch16.7 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2534022-2.patch16.7 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

Status: Postponed » Needs work

The last submitted patch, 2: 2534022-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed

Yeah, no kidding, testbot. Still postponed.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2534022-6.patch22.75 KB
new interdiff-2534022-2-6.txt11.09 KB

Moved the tests into the Drupal\node\Tests\Migrate namespace, and added all view mode migration stuff.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2534022-7.patch24.14 KB
new interdiff-2534022-6-7.txt1.05 KB

Derp, forgot to move a unit test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2534022-8.patch24.14 KB

Ugh...remember, kids, when you move a test, it helps to actually move the test.

Or, as this Spongebob meme summarizes: http://cdn.meme.am/instances/500x/35288674.jpg

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review

Unblocked.

The last submitted patch, 6: 2534022-6.patch, failed testing.

The last submitted patch, 7: 2534022-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: 2534022-8.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534022-13.patch24.83 KB
new interdiff-2354022-8-13.txt802 bytes

It's kind of amazing how a single bad use statement can bring down the entire house of cards...

Status: Needs review » Needs work

The last submitted patch, 13: 2534022-13.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534022-15.patch25.88 KB
new interdiff-2534022-13-15.txt744 bytes

Go again?

Status: Needs review » Needs work

The last submitted patch, 15: 2534022-15.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534022-17.patch26.4 KB
new interdiff-2534022-15-17.txt389 bytes

My kingdom for a green!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work

After applying all the move changes, I believe the following need to be moved from migrate_drupal.source.schema.yml to the node module:

  • migrate.source.d6_node_type
  • migrate.source.d6_node
  • migrate.source.d6_node_revision
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2534022-19.patch28.16 KB
new interdiff-2534022-17-19.txt3.09 KB

Moved.

Status: Needs review » Needs work

The last submitted patch, 19: 2534022-19.patch, failed testing.

The last submitted patch, 19: 2534022-19.patch, failed testing.

phenaproxima queued 19: 2534022-19.patch for re-testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review

Testbot and its weird failures.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6feb57b and pushed to 8.0.x. Thanks!

  • alexpott committed 6feb57b on 8.0.x 
    Issue #2534022 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.