The LDAP integration with other modules could be easier with small changes: removing the cached result from the email template verification and the form submission dependency.
For instance: if you need to use the module "Email Change Confirmation" it will conflict with LDAP email template verification. The first module will generate a link and send it to the user for email confirmation but LDAP will not allow the link to be accessed if the user account has the temporary email template generated by the account creation when the user has no email data in the LDAP server and LDAP module is configured to verify the email template.
In this scenario the user has no valid email and is not able to confirm his new email.
The avaliable patch will make the integration between LDAP and "Email Change Confirmation" works.
It will also allow the template verification to work better with other email modules.
Comments
Comment #1
gilsbert commentedHi.
This is the first version for the patch to attend this issue.
It could be better if the LDAP UI allows to configure which urls should not be tested for the email template verification. This way the url "user/email-change" could not be hardcoded and could be configured.
Anyway this patch is working and I'm greatful to share it.
Regards,
Gilsberty
Comment #2
grahlComment #3
grahlHi
The patch in its current form won't get committed.
Please reopen this issue if you have a proposal which does not hardcode your specific module. I'm fine with additional module-alter hooks to allow other modules to work with LDAP but this specific solution, including the removal of LDAP required functionality, won't get added.
Comment #4
dbiscalchin commentedHi grahl,
I am facing this problem too, so I would like to help you. I agree that hardcoding is not a good solution, but just creating hooks would require additional patches to integrate each other module too, because they would have to implement these hooks. So I think that allowing the user to configure the exceptions through the UI as proposed by gilsbert would be simple and yet flexible solution.
Thus, I ask you if I write a patch with this setting on the UI it would be approved.
Regarding the removed cache, I can try to bring it back, but only for URLs that are not configured as exceptions.
Regards,
Daniel
Comment #5
grahlHi Daniel
For 8.x such an addition to the UI would get in, if the patch itself was well made.
The data model of 7.x is notoriously difficult to work with so I'd not be willing to spend time for a legacy platform on such a niche feature and thus would recommend adding a hook if this really is needed for other modules and not just ""Email Change Confirmation", to save all of us time.
If you want to work on a patch for 7 for your preferred solution and can get others to help you get it into RTBC I'd consider committing it but only if a port to 8.x was included, as well.
I personally would probably stick with a custom patch for this particular problem, if it affected me.
Comment #6
dbiscalchin commentedHi grahl,
Unfortunately, I'm not working with Drupal 8 yet. So I will stick with your idea for now and just use a custom patch. Later on, I may be able to write a patch for both, Drupal 7 and Drupal 8.
I am sending the updated patch, which works with the latest version of LDAP, in case someone else needs it.
Thanks,
Daniel
Comment #7
grahlComment #8
dbiscalchin commentedRerolling
Comment #9
grahlClosing issue as outdated due to no further development on 7.x, if you feel this issue is still relevant and you are willing to work on a patch and/or debug the problem, please reopen.