Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The unit test is failing to pass currently.
Proposed resolution
Fix the tests to make them pass :)
Comment | File | Size | Author |
---|---|---|---|
#1 | libraries-unittests-fail-2530042-1.patch | 1.25 KB | s_leu |
Comments
Comment #1
s_leu CreditAttribution: s_leu at MD Systems GmbH commentedAdding a patch that fixes the fails for the current code in 8.x-3.x. Please note, a part of this patch is also mentioned in #2525898: Depricated setFactoryMethod(). Update needed to support Symfony 3.0 in core
Comment #2
rjacobs CreditAttribution: rjacobs commentedThanks for the note about the overlap with #2525898: Depricated setFactoryMethod(). Update needed to support Symfony 3.0 in core (I'm the one who opened #2525898).
I suppose we should try to remove the overlap between those issues, either by closing #2525898 in favor of this issue, or by removing the common part of the patch in this issue. Either way is fine by me though I have a slight preference for the latter. My reasoning is that issue in #2525898 (the deprecated setFactoryMethod() exception) has ramifications not only for Libraries API tests but it also blocks testing on any other contrib project that declares it as a dependency, no matter what parts of the API that project uses. So addressing it in isolation may get it pushed through faster. That said, if a maintainer is willing to knock-out all the test failures in one go, all the better.
Comment #3
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedThis patch (minus the hunk already committed in #2525898) would get Drupal\libraries\Tests\LibrariesUnitTest working again, which would be good. The thing is I don't think any of the test coverage from LibrariesUnitTest will really be applicable going forward as the static methods tested will possibly become obsolete. Anyway, I suppose committing this couldn't hurt anything and would help keep tests passing until we can officially remove the obsolete chunks.
Comment #5
rjacobs CreditAttribution: rjacobs at Center for Research Libraries commentedCommitted the relevant hunk. As noted earlier it looks like these tests will get replaced soon.