This may go unnoticed outside of automated testing, but it's definitely an issue. Now that Drupal core uses Symfony 3.0, several 2.7.0 concepts are depreciated including factory_service and factory_method in service definitions.

The related change record is https://www.drupal.org/node/2489948

I noticed this as I have a project that has a dependency on Libraries API and my project's tests were producing a barrage of warnings similar to:

User deprecated function: Symfony\Component\DependencyInjection\Definition::setFactoryMethod(get) is deprecated since version 2.6 and will be removed in 3.0. Use Definition::setFactory() instead

These appear to stem from the cache.libraries services definition in libraries.services.yml.

Fix should be easy. I'll try to get a patch going shortly.

CommentFileSizeAuthor
#1 libraries-fix_deprecated_setFactoryMethod-2525898-1.patch778 bytesrjacobs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rjacobs’s picture

rjacobs CreditAttribution: rjacobs commented
Status: Active » Needs review
FileSize
libraries-fix_deprecated_setFactoryMethod-2525898-1.patch778 bytes

Ok, here we go. I'm not sure if the testbots will pick this up yet as it looks like there are some pending failures that may be postponing tests on the project.

rjacobs’s picture

rjacobs CreditAttribution: rjacobs commented
Priority: Normal » Critical

I'm going to take the liberty of escalating this as per the issue priority level guidelines. I'm assuming that this project follows the same guidelines as core in this regard, but if not I won't be offended if someone overrides the priority change. The main concern here is that this issue not only postpones all automated tests for Libraries API, but also for any other contrib projects that simply declare it as a dependency (here's an example).

hutch’s picture

hutch CreditAttribution: hutch commented

The patch applies cleanly to a fresh clone and the error message I was seeing when I ran drush cr has gone.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Just tested this patch by running JwPlayerConfigurationTest (Jw player project) which was broken because of this core change and it works fine.

  • rjacobs authored d747943 on 8.x-3.x 
    Issue #2525898 by rjacobs, jonhattan: Fix obsoleted cache bin...
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Fixed now. Sorry, for taking so long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.