It's a minor thing, but visible to users.
In CKEditor context menu "Refresh" and "Copy" commands are not translatable. Also there's no translation for "Add a caption".

After short investigation it occured that scald\modules\library\dnd\plugins\ckeditor\lang\en.js script is incomplete. There should be lines:

atom_refresh: Drupal.t('Refresh'),
atom_copy: Drupal.t('Copy'),
properties_has_caption: Drupal.t('Add a caption'),
CommentFileSizeAuthor
#6 using-the-wrong-translation-in-drupal-for-dndck4-2529956-6.patch863 bytesnagy.balint
#4 using-the-wrong-translation-in-drupal-for-dndck4-2529956-4.patch925 bytesnagy.balint

Comments

gpietrzak’s picture

gpietrzak
Primary language Polish
Location Wrocław
commented
Issue summary: View changes
nagy.balint’s picture

nagy.balint commented

@vindicator:
Those strings are only needed in the dndck4 plugin, and if you check the language file for the dndck4 plugin under modules/library/dnd/plugins/dndck4/lang/en.js
then you can see that the strings are there.

So in this case your issue is due something else. Maybe that language file is not properly included?

nagy.balint’s picture

nagy.balint commented

Aye seems like the issue is in function dnd_library()
Where only the legacy plugin's language file is referenced...

In fact it should load the one related to the enabled plugin.

nagy.balint’s picture

nagy.balint commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new using-the-wrong-translation-in-drupal-for-dndck4-2529956-4.patch925 bytes

So something like this could work.

Please test.

DeFr’s picture

DeFr commented

I'd have written the conditional assignment, given that there's only two type of plugin right now, as

$plugin = mee_store_format() !== 'embed_div' ? 'ckeditor' : 'dndck4';

More importantly though, the problem occurred on one of our in development site too, and I can confirm that the patch fix it :-) Leaving at NR for now to let the OP chime in, but for me that's good to go, with or without the style fix.

nagy.balint’s picture

nagy.balint commented
StatusFileSize
new using-the-wrong-translation-in-drupal-for-dndck4-2529956-6.patch863 bytes

Thanks,
here is the updated patch.

  • nagy.balint committed b7ca8cc on 7.x-1.x 
    Issue #2529956 by nagy.balint, vindicator, DeFr: There are missing...
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Tested it again, it seems to work fine for me. Committed.

Of course after applying this patch its not enough to clear the cache, but also a page has to be visited that has DND on it, so the new strings are added, and then they will appear under interface translation.

gpietrzak’s picture

gpietrzak
Primary language Polish
Location Wrocław
commented

#6 works great for me, thank you all for the response!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.