Closed (fixed)
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Jul 2015 at 16:28 UTC
Updated:
12 Nov 2015 at 09:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirThat is more or less by design. But the effect it has on deleting is definitely not intendted.
Comment #2
miro_dietikerSee also this issue that explains the situation / limitation: #2461695: Support asymmetric translations
From the README.txt:
Chances are you don't want to do what you did.
If you fix the setup, is the bug still pending?
Comment #3
tassilogroeper commented@miro_dietiker: updated the setup. the three points of the further notes are solved. But the initial bug still remains.
Comment #4
miro_dietikerBack to active then. Will check, provide feedback, fix.
Comment #5
miro_dietikerCan reproduce. That's a critical thing indeed.
(Pretty sure this worked once.)
Let's start with extending a test and then identify and fix the issue...
Comment #6
sasanikolic commentedThis is a core bug. This is an opened issue to fix it.
Comment #7
berdirThe core issue was fixed, which should have fixed this.
We still want test for this, however so changing to a task.
Comment #8
tduong commentedUploaded patch for issue #2527644:
Comment #9
sasanikolic commentedI think we just need to extend the existing test (
testParagraphTranslation()), not add a new one for that, since this adds lots of loading time to our test.It should be as easy as two lines of code at the end. :)
Comment #10
tduong commentedUploaded patch:
testParagraphTranslation()adding the saving command for the original content on second request :)Comment #11
sasanikolic commentedMissing dot at the end of the sentence.
No need for line breaks. You can write one sentence after another, and limit the line to 80 chars.
Comment #12
sasanikolic commentedAlso, don't forget to post interdiffs.
Comment #13
jeroen.b commentedAre we sure that assertNoText works correctly with the line breaks?
Comment #14
miro_dietikerI think testing for "The content has either been modified by another user" is perfectly enough.
(But i think it's a redundant check to the "...has been updated." and could be omitted if we check for success explicitly..)
Comment #15
sasanikolic commentedHmm, I checked... It doesn't work correctly with line breaks.
Comment #16
tduong commentedUploaded patch:
assertNoText()Yes, I also have checked the thing and yes, it does not work!
Comment #17
sasanikolic commentedNot sure if we need the
assertNoText()or not. But without is fine for me.Comment #18
tduong commentedTo be consistent with the whole method
testParagraphTranslation(), we may need also the lastassertNoText()as well, since also for // Check the english translation. and // Check the french translation. we do have double checks.But I also find it a bit redundant (if we successfuly saved the paragraph then the
assertNoText()will always pass as well).Comment #20
jeroen.b commentedThanks, pushed to dev!