Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
3 Jul 2015 at 00:54 UTC
Updated:
29 Jul 2015 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lostkangaroo commentedVery much in favor of this one, I wonder though if it should contain an error rather then returning NULL on missing templates.
Comment #2
neclimdultests
Comment #3
lostkangaroo commentedTime to push this into the RTBC stack. Now with a test!! I have been running this patch for most of my migrations in the last few days and it has been thoroughly tested.
Comment #4
phenaproximaThis is a blocker for #2530030: Create the migrate builder plugin type.
Comment #5
benjy commentedNULL should be capitals
Our coding standards has this on one line.
Missing function comment.
Comment #6
phenaproximaComment #7
phenaproximaThe previous patch was just minor style fixes, so back to RTBC.
Comment #8
prajaankit commentedComment #9
phenaproxima@prajaankit, what is your patch adding or removing? All I see are formatting changes. Please post some explanation, and an interdiff.
Comment #10
neclimdul#8 just adds incorrect spacing.
Committers: #6 is RTBC.
Comment #11
neclimdulupdate credit.
Comment #12
phenaproximaComment #13
phenaproximaComment #14
phenaproximaComment #15
phenaproximaComment #16
mikeryanPatch is double-plus good, and blocks (at least) #2530030: Create the migrate builder plugin type and #2522660: Templates Broke migrate-manifest. Should we tag this "Migrate critical"?
Comment #17
phenaproximaIn a word: yes.
Comment #18
phenaproximaComment #19
alexpottCommitted 92965c5 and pushed to 8.0.x. Thanks!