empty excludeSelectors array causes javascript exception [#2522462]

The fix posted for #2493443: The ajax_html_ids list hits server limit. does not account for the case when there are no selectors to exclude, and in jQuery 1.7 at least :not() causes an error. just adding a test on the array length fixed it for me.

Comment	File	Size	Author
#1	wysiwyg-excludeSelectors-2522462.patch	558 bytes	brad.bulger

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

brad.bulger CreditAttribution: brad.bulger commented 3 July 2015 at 00:14

Status:

Active

» Needs work

File	Size
wysiwyg-excludeSelectors-2522462.patch	558 bytes

Comment #2

3 July 2015 at 14:14

TwoD committed 727a208 on 7.x-2.x authored by brad.bulger

- #2522462 by brad.bulger: Fixed empty excludeSelectors array causes JS...

Comment #3

TwoD

Swedish

Sweden

CreditAttribution: TwoD as a volunteer commented 3 July 2015 at 14:16

Status:

Needs work

» Fixed

Nice catch, forgot to test that because I always had CKEditor enabled.
The if-statement also needs to wrap the clearing of the list when there are no exclusions to perform. Other than that the patch looks great!
I made the minor changed and pushed it to the 7.x-2.x branch.

Thanks a lot!