Current version of HHVM does not support SimpleXMLIterator. So I wrote to make mollom works.

CommentFileSizeAuthor
#6 mollom-no-SimpleXMLIterator-support.patch2.86 KBnoomz
#2 mollom-no-SimpleXMLIterator-support.patch2.85 KBnoomz
mollom-no-SimpleXMLIterator-support.patch2.81 KBnoomz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, mollom-no-SimpleXMLIterator-support.patch, failed testing.

noomz’s picture

noomz CreditAttribution: noomz commented
FileSize
mollom-no-SimpleXMLIterator-support.patch2.85 KB

The last patch file is fail. I upload the new one.

noomz’s picture

noomz CreditAttribution: noomz commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: mollom-no-SimpleXMLIterator-support.patch, failed testing.

noomz’s picture

noomz CreditAttribution: noomz commented
Status: Needs work » Needs review
noomz’s picture

noomz CreditAttribution: noomz commented
FileSize
mollom-no-SimpleXMLIterator-support.patch2.86 KB
eshta’s picture

eshta CreditAttribution: eshta at Acquia commented
Status: Needs review » Active

This actually should be submitted as a pull request against the Mollom PHP library here: https://github.com/Mollom/MollomPHP
It is only included in the Mollom module. With that said I'm fine with keeping the conversation here if it's easier and I can just push the changes into github when decided.

+++ ./includes/mollom.class.inc	2015-07-02 16:29:51.816975125 +0700
@@ -507,9 +507,15 @@
+          if (class_exists('SimpleXmlIterator')) {

Seems like this would be more readable if the parseXML was just generalized to take a response and then the details could be ironed out in there.