Comments Report Abuse

The theming of comments was not handling additional links correctly. I've pushed some new code to the oa_comments module in commit: 6c6a2f9. That should allow any normal comment link to appear now. This will be in the 2.43 release.

@bherring: have a look here (that's from http://cgit.drupalcode.org/oa_comment/)!

Probably need to post this over in the Comment Abuse module. The 2.43 version of Atrium now adds any links added by other modules. Links are required to have a "title" and "href" field. Sounds like the link added by Comment Abuse is missing the "href" field.

I believe http://cgit.drupalcode.org/comment_abuse/tree/comment_abuse.module?h=7.x... is the code that creates the 'link' for comment abuse.

As seen by theme_links documentation

href: The link URL. If omitted, the 'title' is shown as a plain text item in the links list.
html: (optional) Whether or not 'title' is HTML. If set, the title will not be passed through check_plain().

what comment abuse is doing is valid for comment links, but makes it rather hard for anyone who wants to override the themeing of links. Comment abuse links are links, but have special classes/etc. from ctools functions (which return the link rendered) to make the ajax work.

So, comment abuse isn't doing anything wrong, but what is doing makes it harder for people to customize the display of comment links.

Perhaps openatrium can print any comment links that don't have href in a different area?

Yep, we can probably handle this then. Didn't realize href was optional. The code in oa_comment.theme.inc around line 112 just needs another if case for this.

bherring:

    elseif (!isset($link['href'])) {
      $links[$key] = !empty($link['html']) ? $link['title'] : check_plain($link['title']);
    }

Does this on the mentioned line (112 of oa_comment.theme.inc) fix comment abuse?

Figured I could actually make a patch

This occurs with anything that adds links to comments like http://drupal.org/project/comment_registration

Array ( 
[title] => Log in or register to post comments 
[html] => 1
)

Both "Log in" and "register" are both links themselves

The patch worked for me after clearing caches and registry
drush cc all
drush rr --fire-bazooka

The patch purely allows the link to appear, and based on the comment about there being an ajax error, looks the patch worked for bherring. So the original issue is fixed, but looks like new issues were revealed, though I'm guessing those issues may be comment abuse issues instead of oa issues.

Should add, patch commited to oa_comment

I need to flag comments... did you figure this out?

Comment Abuse module works fine for me using their latest dev version on current OA.