Closed (fixed)
Project:
Entity Embed
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Jun 2015 at 17:44 UTC
Updated:
28 Sep 2015 at 03:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dave reidComment #2
dave reidComment #3
dave reidComment #4
cs_shadow commentedI'm pretty sure this used to work in the past so something recent must have broken this.
Comment #5
slashrsm commentedComment #6
dave reidComment #7
dave reidStarting to become a larger annoyance. It seems that all of our form elements using #value => true on the second step of the form are not coming through into the form state on the ajax change, which means that the 'step' gets changed back to 'embed' and the first step of the form.
Comment #8
daniel.bosenDoes anyone have any idea how to fix this, or where I might start looking for fixing it myself?
Comment #9
dave reid@daniel.bosen All I can tell is that our form values and storage values (which includes the current form "step") get lost when submitting anything via the second step AJAX, so it reverts back to the first step of the form. I'd welcome any help in debugging this.
Comment #10
chripu commentedSee patch for a quick hack.
The
data-entity-idordata-entity-uuidis not persisted via$form_state->set(...)across requests.So submitting the values with hidden input fields solved the problem.
Comment #11
daniel.bosenThis patch works form me.
Comment #12
dave reidComment #13
devin carlson commentedIt sounds like this may be related to #2540850: (regression) EditorImageDialog alignment & captioning are not working.
Comment #14
dave reidConverted to a PR at https://github.com/drupal-media/entity_embed/pull/180 and merged. I tried emulating the same fix that #2540850: (regression) EditorImageDialog alignment & captioning are not working did but it didn't seem to work.