There are some issues with the Views Content submodule in CTools when running PHP 5.4 or newer:

  • Strict warning: Declaration of views_content_plugin_display_panel_pane::options_submit() should be compatible with views_plugin_display::options_submit($form, &$form_state) in views_include_handler() (line 98 of sites/all/modules/contrib/views/includes/handlers.inc).

(there might be more)

CommentFileSizeAuthor
#5 ctools-n2512850-4.patch1.58 KBmw4ll4c3
#1 ctools-n2512850-1.patch843 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new ctools-n2512850-1.patch843 bytes

This should fix it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +PHP 5.4
mw4ll4c3’s picture

mw4ll4c3 commented

I had needed to do the same for options_form() as per #1224032-5: Fix Strict Warnings

The patch in #5 also includes your change to options_submit()

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@mw4ll4c3: Please update this patch with your additional change, that other issue is already closed.

mw4ll4c3’s picture

mw4ll4c3 commented
StatusFileSize
new ctools-n2512850-4.patch1.58 KB

Attaching here for convenience / visibility

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Reviewed & tested by the community

I tested both fixes in patch #5 and the errors were fixed in both spots.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Fixed!

  • japerry committed 40e4905 on 6.x-1.x authored by mw4ll4c3 
    Issue #2512850 by DamienMcKenna, mw4ll4c3: PHP 5.4+ compatibility
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Just to say it - woohoo, thanks for adding this to the new release, japerry!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mw4ll4c3’s picture

mw4ll4c3 commented
Status: Closed (fixed) » Reviewed & tested by the community

In the latest, this seems to have been only partially applied! Patch #1 is still required to remedy the original error (and Patch #5 will throw an error, because its additional change was made.)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Closed (outdated)