There are some issues with the Views Content submodule in CTools when running PHP 5.4 or newer:

  • Strict warning: Declaration of views_content_plugin_display_panel_pane::options_submit() should be compatible with views_plugin_display::options_submit($form, &$form_state) in views_include_handler() (line 98 of sites/all/modules/contrib/views/includes/handlers.inc).

(there might be more)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
843 bytes

This should fix it.

DamienMcKenna’s picture

Issue tags: +PHP 5.4
mw4ll4c3’s picture

I had needed to do the same for options_form() as per #1224032-5: Fix Strict Warnings

The patch in #5 also includes your change to options_submit()

DamienMcKenna’s picture

@mw4ll4c3: Please update this patch with your additional change, that other issue is already closed.

mw4ll4c3’s picture

FileSize
1.58 KB

Attaching here for convenience / visibility

Michelle’s picture

Status: Needs review » Reviewed & tested by the community

I tested both fixes in patch #5 and the errors were fixed in both spots.

japerry’s picture

Status: Reviewed & tested by the community » Fixed

Fixed!

  • japerry committed 40e4905 on 6.x-1.x authored by mw4ll4c3
    Issue #2512850 by DamienMcKenna, mw4ll4c3: PHP 5.4+ compatibility
    
DamienMcKenna’s picture

Just to say it - woohoo, thanks for adding this to the new release, japerry!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mw4ll4c3’s picture

Status: Closed (fixed) » Reviewed & tested by the community

In the latest, this seems to have been only partially applied! Patch #1 is still required to remedy the original error (and Patch #5 will throw an error, because its additional change was made.)

joelpittet’s picture

Status: Reviewed & tested by the community » Closed (outdated)