see #1223996-3: Strict warning: Declaration of * should be compatible with that of views_handler::*

Strict warning: Declaration of views_content_plugin_display_panel_pane::options_submit() should be compatible with that of views_plugin_display::options_submit() in views_include_handler() (line 76 of views/includes/handlers.inc).
CommentFileSizeAuthor
#5 ctools-strict-views3-1224032-5.patch1.58 KBmw4ll4c3
#2 ctools-1224032-2.patch1.33 KBmikeytown2
#1 ctools-1224032-1.patch843 bytesmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new ctools-1224032-1.patch843 bytes
mikeytown2’s picture

mikeytown2 commented
Title: Strict warning: Declaration of views_content_plugin_display_panel_pane::options_submit() should be compatible » Fix Strict Warnings
StatusFileSize
new ctools-1224032-2.patch1.33 KB

Different warning

Strict warning: Only variables should be passed by reference in page_manager_user_view() (line 84 of ctools/page_manager/plugins/tasks/user_view.inc).
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed. Doesn't look like this needs to apply to D7 at all.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mw4ll4c3’s picture

mw4ll4c3 commented
Issue summary: View changes
StatusFileSize
new ctools-strict-views3-1224032-5.patch1.58 KB

In Views 3, options_submit() no longer passes the form by reference.

There are obviously some logistical issues that prevent this from being committed... but for anyone who needs it, here's the patch to declarations in _display_ctools_context.inc and _display_panel_pane.inc

mw4ll4c3’s picture

mw4ll4c3 commented

Anyone wandering into this, the efforts of #5 now take place here: #2512850: PHP 5.4+ compatibility