Remove query string from path in FeedsEnclosure.

Yup, that is a bug, but, it existed before the patch, we just weren't as strict.

As an iterim fix, you can strip the token from the URL with feeds_tamper.

Can you tell me what the URL looks like it the feed?

I have a similar issue with 7.x-2.0-alpha9. I'm importing feeds from Facebook using Feeds_ex JsonPath parser and importing images from urls with query strings fails without showing any error messages. I'm not using Feeds Image Grabber, I tested it, but could not get it to work at all.

Stripping the tokens using feeds_tamper cannot be done, because that removes access to the images.

Downgrading Feeds to 7.x-2.0-alpha8 fixed the problem!

Yup.

Thank you @twistor. Work for me

Hello,

I am trying to import images using feeds from another CMS. I am running in an issue where removing the query string is causing some issues as in this CMS I do need the query string in the URL.

As feeds removes it the images can not be fetched. I think its a Microsoft CMS and despite the image url not being ideal (it uses the query string) that is how it works. Also feeds should probably just use just some better method like running the image through image_get_info() instead of relying on the image name or format.

best regards
Joao Garin

I am proposing a patch here to roll back this to the previous state. Since this breaks the current site I am working on. Probably others as well.

Best regards
Joao Garin

How is this breaking things? Removing the query string only happens for the local file name, not the URL used to fetch the file.

Hello,

No this affects files being fetched outside Drupal.

In lines 457 of FeedsParser.inc :

$filename = $this->getLocalValue();
 if (module_exists('transliteration')) {
    require_once drupal_get_path('module', 'transliteration') . '/transliteration.inc';
    $filename = transliteration_clean_filename($filename);
 }

$file = file_save_data($this->getContent(), $destination . $filename);
         

getLocalValue() function calls getSafeFilename() which has these lines in the patches.

Best regards

Probably related: #2611014: Feeds doesn't import remote images which have no proper extension (such as ASP)

Yes @kenorb I am thinking they are probably related.

Drupal 7 reached end of life and the D7 version of Feeds is no longer being developed. To keep the issue queue focused on supported versions, we’re closing older D7 issues.

If you still have questions about using Feeds on Drupal 7, feel free to ask. While we won’t fix D7 bugs anymore, we’re happy to offer guidance to help you move forward. You can do so by opening (or reopening) a D7 issue, or by reaching out in the #feeds channel on Drupal Slack.

If this issue is still relevant for Drupal 10+, please open a follow-up issue or merge request with proposed changes. Contributions are always welcome!