Comments

eamonogealagain’s picture

eshta’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

This works for me locally. Thanks for the contribution.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: navbar-detect-modernizr-version-2509740-0.patch, failed testing.

eshta’s picture

Status: Needs work » Needs review
StatusFileSize
new853 bytes

Re-rolled against dev branch.

eshta’s picture

Status: Needs review » Reviewed & tested by the community

jippie1948’s picture

This patch works fine!
Also the instructions might be adapted as the download page of the modernizr web site has been changed.

Thanks and best wishes, jippie.

MickL’s picture

Please update dev and latest stable release. this issue took me some hours!

Dorayaki’s picture

estha patch works for navbar 1.6 stable version.
I tried manually edit the navbar module
I went to line 847 and 851 and change it to
'pattern' => '#[Mm]odernizr\s+[Vv]?([0-9\.]+)#',
Thank you.

pepe631’s picture

StatusFileSize
new13.51 KB
new50.26 KB

Hi,

I have tried a lot of things (apply mentioned patch, cache clearance, trying older versions of navbar...) and still, after navbar picked up Modernizr's js, I am unable to make it work. See attached pics.
Thanks.

EDIT: I managed to solve it. It was all about the privileges on my server folder named ".../libraries/..." dont know why yet, but it automatically set them to 0700 octal (rwx------), so every fresh new created folder is invisible.

calebyoder’s picture

It was telling me (in the status report) that it couldn't get the version. I did what #9 said and the notice went away.
Thanks!

AlfredK’s picture

Confirm #9 fixed the Modernizr issuse

keopx’s picture

StatusFileSize
new645 bytes

NOTE: This patch only works in 7.x-1.6 version

The #2509740-4: Modernizr 3 version number isn't detected patch works in dev branch

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 13: 2509740-only_7.x-1.6_version.patch, failed testing.

eshta’s picture

It appears that the changes for Modernizr 3 also mean that you no longer have to download the development build in order to get the version number detection as it is now included in the minified version as well. I'm thinking this means we can just drop that whole section in the instructions and just provide a link/instructions for the production build with the right items checked. I *think* that this started with version 2.8.3. YAY simplification.

eshta’s picture

Component: Code » Documentation
Assigned: Unassigned » eshta
Category: Bug report » Task
Status: Needs work » Needs review

This is committed - but the changes still need to be made to documentation.

====================================

A preconfigured version of the modernizr library

  • Click the above link to take you to the Modernizr website with the appropriate configuration pre-checked
  • Click the "Build" button to open the build modal window
  • Click the "Download" link in the "Build" line
  • Save as "modernizr-min.js" in your "modernizr" folder within the site's library folder structure

Production version renamed to be available as modernizr-min.js
Development version renamed to be available as modernizr.js
You can create this version by unchecking "minify" in the "Options" section
While Navbar will use the production, minified version when available, the development version is needed in order to determine the library version (See also https://www.drupal.org/node/2509740 if your version is not being detected). Unfortunately this information is not included in the minified Modernizr code.

If you wish to generate a custom Modernizr build for use with other modules, be sure you have checked the following:

  • Input Types (HTML5)
  • SVG (Misc.)
  • Touch Events (Misc.)
  • Add CSS Classes (Extra)
  • Modernizr.addTest (Extensibility)
  • Modernizr.testStyles (Extensibility)
  • Modernizr._prefixes (Extensibility)
  • elem-details (Non-core detects)
eshta’s picture

Status: Needs review » Fixed

Updated documentation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.