Closed (fixed)
Project:
Navbar
Version:
7.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
22 Jun 2015 at 01:06 UTC
Updated:
21 Dec 2015 at 20:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eamonogealagain commentedComment #2
eshta commentedThis works for me locally. Thanks for the contribution.
Comment #4
eshta commentedRe-rolled against dev branch.
Comment #5
eshta commentedComment #7
jippie1948 commentedThis patch works fine!
Also the instructions might be adapted as the download page of the modernizr web site has been changed.
Thanks and best wishes, jippie.
Comment #8
MickL commentedPlease update dev and latest stable release. this issue took me some hours!
Comment #9
Dorayaki commentedestha patch works for navbar 1.6 stable version.
I tried manually edit the navbar module
I went to line 847 and 851 and change it to
'pattern' => '#[Mm]odernizr\s+[Vv]?([0-9\.]+)#',Thank you.
Comment #10
pepe631 commentedHi,
I have tried a lot of things (apply mentioned patch, cache clearance, trying older versions of navbar...) and still, after navbar picked up Modernizr's js, I am unable to make it work. See attached pics.
Thanks.
EDIT: I managed to solve it. It was all about the privileges on my server folder named ".../libraries/..." dont know why yet, but it automatically set them to 0700 octal (rwx------), so every fresh new created folder is invisible.
Comment #11
calebyoder commentedIt was telling me (in the status report) that it couldn't get the version. I did what #9 said and the notice went away.
Thanks!
Comment #12
AlfredK commentedConfirm #9 fixed the Modernizr issuse
Comment #13
keopxNOTE: This patch only works in 7.x-1.6 version
The #2509740-4: Modernizr 3 version number isn't detected patch works in dev branch
Comment #15
eshta commentedIt appears that the changes for Modernizr 3 also mean that you no longer have to download the development build in order to get the version number detection as it is now included in the minified version as well. I'm thinking this means we can just drop that whole section in the instructions and just provide a link/instructions for the production build with the right items checked. I *think* that this started with version 2.8.3. YAY simplification.
Comment #17
eshta commentedThis is committed - but the changes still need to be made to documentation.
====================================
A preconfigured version of the modernizr library
Production version renamed to be available as modernizr-min.jsDevelopment version renamed to be available as modernizr.js
You can create this version by unchecking "minify" in the "Options" section
While Navbar will use the production, minified version when available, the development version is needed in order to determine the library version (See also https://www.drupal.org/node/2509740 if your version is not being detected). Unfortunately this information is not included in the minified Modernizr code.
If you wish to generate a custom Modernizr build for use with other modules, be sure you have checked the following:
Comment #18
eshta commentedUpdated documentation.