Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As shown in the attachment, there is no left padding in the LTR mode before the word "Text", but a padding-right is inserted into the RTL mode. This padding should be removed.
Comment | File | Size | Author |
---|---|---|---|
#20 | Tags RTL after patch.png | 143.17 KB | NikitaJain |
#20 | Tags LTR after patch1.png | 144.17 KB | NikitaJain |
#20 | Tags RTL before.png | 146.2 KB | NikitaJain |
#20 | Tags LTR before.png | 146.74 KB | NikitaJain |
#18 | 2509390-18.patch | 548 bytes | herom |
Comments
Comment #1
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedAttached is a patch that fixed the issue
Comment #2
nathanlawsn CreditAttribution: nathanlawsn commentedPatch in #1 fixes this issue.
Tags LTR Before:
Tags RTL Before:
Tags LTR After:
Tags RTL After:
Comment #3
nathanlawsn CreditAttribution: nathanlawsn commentedComment #4
LewisNyman CreditAttribution: LewisNyman at Wunder commentedIn our CSS standards, we always have a blank line before every comment. See: https://www.drupal.org/node/1887862
Comment #5
nathanlawsn CreditAttribution: nathanlawsn commentedComment #6
nathanlawsn CreditAttribution: nathanlawsn commentedComment #7
Eski CreditAttribution: Eski commentedPatch in #5 looks good and meets the coding standards, as mentioned in #4.
Comment #8
Manjit.Singh@Eski Need some more screenshots including LTR after #5 patch to avoid regression issues.
Comment #9
Maninders CreditAttribution: Maninders at Srijan | A Material+ Company commentedComment #10
Maninders CreditAttribution: Maninders at Srijan | A Material+ Company commentedI applied a patch #5, but there was an issue in rtl.
Please check screenshot of rtl-before.jpg.
And i have resolved that issue please check screenshot rtl-after.jpg.
And review patch.
Comment #11
jim005 CreditAttribution: jim005 at WebSenso commentedWe're working on at DrupalCon Barcelona at the French team table ;-)
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedI notice that the previous patchs change something in content.css but this file doesn't exist anymore.
We find the problem in the main-content.css so there is a new patch to review.
Thanks to Knee-X with my mentor Chipway during DrupalCon Barcelona
Comment #13
Anonymous (not verified) CreditAttribution: Anonymous commentedHere's a screenshot showing that the patch works.
Comment #14
jim005 CreditAttribution: jim005 at WebSenso commentedTest passed the patch looks ready to go RTBC. ;-)
Comment #17
biguzis CreditAttribution: biguzis at Wunder commentedRetested, got zero fails. Set to RTBC.
Comment #18
herom CreditAttribution: herom commentedUnfortunately, the patch in #12 isn't in the right direction. it breaks
[dir="rtl"] .region-content ul
in other places.Here is the actual problem (taken from firebug):
An RTL rule overriding an unrelated rule, due to more specificity.
I've posted a more proper fix (in line with #10 and older patches), and a screenshot for after the patch.
Comment #19
herom CreditAttribution: herom commentedComment #20
NikitaJain CreditAttribution: NikitaJain commentedTested the 2509390-18.patch on Firefox and chrome browser for Ubuntu 14.04 and its working fine.
Padding removed from RTL mode after applying the patch.
Screenshot attached.
Comment #21
alexpottCommitted 6d7ce14 and pushed to 8.0.x and 8,1.x. Thanks!