Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Bartik theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Jun 2015 at 15:12 UTC
Updated:
6 Jan 2016 at 00:24 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
munzirtaha commentedAttached is a patch that fixed the issue
Comment #2
nathanlawsn commentedPatch in #1 fixes this issue.
Tags LTR Before:
Tags RTL Before:
Tags LTR After:
Tags RTL After:
Comment #3
nathanlawsn commentedComment #4
lewisnymanIn our CSS standards, we always have a blank line before every comment. See: https://www.drupal.org/node/1887862
Comment #5
nathanlawsn commentedComment #6
nathanlawsn commentedComment #7
Eski commentedPatch in #5 looks good and meets the coding standards, as mentioned in #4.
Comment #8
manjit.singh@Eski Need some more screenshots including LTR after #5 patch to avoid regression issues.
Comment #9
maninders commentedComment #10
maninders commentedI applied a patch #5, but there was an issue in rtl.
Please check screenshot of rtl-before.jpg.
And i have resolved that issue please check screenshot rtl-after.jpg.
And review patch.
Comment #11
jim005 commentedWe're working on at DrupalCon Barcelona at the French team table ;-)
Comment #12
Anonymous (not verified) commentedI notice that the previous patchs change something in content.css but this file doesn't exist anymore.
We find the problem in the main-content.css so there is a new patch to review.
Thanks to Knee-X with my mentor Chipway during DrupalCon Barcelona
Comment #13
Anonymous (not verified) commentedHere's a screenshot showing that the patch works.
Comment #14
jim005 commentedTest passed the patch looks ready to go RTBC. ;-)
Comment #17
biguzis commentedRetested, got zero fails. Set to RTBC.
Comment #18
herom commentedUnfortunately, the patch in #12 isn't in the right direction. it breaks
[dir="rtl"] .region-content ulin other places.Here is the actual problem (taken from firebug):
An RTL rule overriding an unrelated rule, due to more specificity.
I've posted a more proper fix (in line with #10 and older patches), and a screenshot for after the patch.
Comment #19
herom commentedComment #20
NikitaJain commentedTested the 2509390-18.patch on Firefox and chrome browser for Ubuntu 14.04 and its working fine.
Padding removed from RTL mode after applying the patch.
Screenshot attached.
Comment #21
alexpottCommitted 6d7ce14 and pushed to 8.0.x and 8,1.x. Thanks!