Rename Field collection entities and field type [#2509252]

I think we can rename the entities and FieldType plugin name so that it'll be more inline with core.

	Old Name	New Name
Field collection config entity	field_collection	field_collection_type
Field collection content entity	field_collection_item	field_collection
Field collection field type	field_collection	field_collection_item

We have similar naming convention for comments in core. Ideas??

I know this is a big change but this make sense IMO.

Comments

Comment #1

jmuzz commented 20 June 2015 at 18:21

I like field_collection_type for the config entity. I'm not sure why field_collection and field_collection_item should be switched though. A field collection item sounds like an item inside a field collection to me, so I think having field collections inside a field collection item would be confusing.

Comment #2

jibran

he/him

Urdu

Toronto, Canada

commented 20 June 2015 at 18:51

Yeah I realized that after the code refactor. I think changing the config entity name is enough but we should definitely do this
renamed: src/Plugin/Field/FieldType/FieldCollection.php -> src/Plugin/Field/FieldType/FieldCollectionItem.php
it's more inline with core.