Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MerryHamster’s picture

MerryHamster’s picture

Status: Active » Needs review
maximpodorov’s picture

Status: Needs review » Needs work

Maybe some wordings corrections are necessary:

  1. +++ b/plugins/relationships/comment_parent.inc
    @@ -0,0 +1,40 @@
    + * Plugin to provide an relationship handler for comment parent.
    

    "a relationship"

  2. +++ b/plugins/relationships/comment_parent.inc
    @@ -0,0 +1,40 @@
    +  'title' => t('Comment parent'),
    

    "Parent comment" - to indicate that the result of the relationship is comment, not node. The same change should be made elsewhere.

MerryHamster’s picture

FileSize
1.37 KB

Ок, I added changes.

MerryHamster’s picture

Status: Needs work » Needs review
maximpodorov’s picture

Status: Needs review » Reviewed & tested by the community

It works and looks reasonable.

DamienMcKenna’s picture

japerry’s picture

Category: Bug report » Feature request
Status: Reviewed & tested by the community » Needs review

Why have a blank settings form? This is a feature request also, not a bug.

DamienMcKenna’s picture

@japerry: You need a blank settings form function otherwise the Panels UI won't give you the settings item in the context menu.

DamienMcKenna’s picture

Version: 7.x-1.7 » 7.x-1.x-dev

.. though after looking at the others in plugins/relationships I'm not sure it's needed.

DamienMcKenna’s picture

FileSize
1.23 KB

This patch removes the empty settings form.

maximpodorov’s picture

Status: Needs review » Needs work

No, no. You removed the form but left the reference in $plugin array.

maximpodorov’s picture

Requirements for forms are so various across the different plugin types!

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
1.17 KB

Ah, thanks for noticing that.

DamienMcKenna’s picture

Moving this to the v7.x-1.10 release plan.

maximpodorov’s picture

I renamed your patch to have more descriptive name.

DamienMcKenna’s picture

This didn't get added to 7.x-1.10.

Chris Matthews’s picture

The 3 year old patch in #16 to comment_parent.inc applied cleanly to the latest ctools 7.x-1.x-dev and if still relevant needs to be added to the #2984057: Plan for CTools 7.x-1.15 release.

joelpittet’s picture

joelpittet’s picture

If someone following this and is using the patch can RTBC this, I'll add it in the next release.

andrey.troeglazov’s picture

I will check it.

rivimey’s picture

@andrey ... bump?

joelpittet’s picture

joelpittet’s picture

Bump too, still looking for an RTBC from someone using this feature

joelpittet’s picture

joelpittet’s picture

Status: Needs review » Fixed

I'll trust it works, thanks @DamienMcKenna, @MerryHamster, et al, I've committed this to the dev branch for 1.18 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.