Maybe some wordings corrections are necessary:
+++ b/plugins/relationships/comment_parent.inc @@ -0,0 +1,40 @@ + * Plugin to provide an relationship handler for comment parent.
"a relationship"
+++ b/plugins/relationships/comment_parent.inc @@ -0,0 +1,40 @@ + 'title' => t('Comment parent'),
"Parent comment" - to indicate that the result of the relationship is comment, not node. The same change should be made elsewhere.
Ок, I added changes.
It works and looks reasonable.
Why have a blank settings form? This is a feature request also, not a bug.
@japerry: You need a blank settings form function otherwise the Panels UI won't give you the settings item in the context menu.
.. though after looking at the others in plugins/relationships I'm not sure it's needed.
This patch removes the empty settings form.
No, no. You removed the form but left the reference in $plugin array.
Requirements for forms are so various across the different plugin types!
Ah, thanks for noticing that.
Moving this to the v7.x-1.10 release plan.
I renamed your patch to have more descriptive name.
This didn't get added to 7.x-1.10.
The 3 year old patch in #16 to comment_parent.inc applied cleanly to the latest ctools 7.x-1.x-dev and if still relevant needs to be added to the #2984057: Plan for CTools 7.x-1.15 release.
If someone following this and is using the patch can RTBC this, I'll add it in the next release.
I will check it.
@andrey ... bump?
Bump too, still looking for an RTBC from someone using this feature
I'll trust it works, thanks @DamienMcKenna, @MerryHamster, et al, I've committed this to the dev branch for 1.18 release.
Issue #2506259 by DamienMcKenna, MerryHamster, maximpodorov, joelpittet...
Automatically closed - issue fixed for 2 weeks with no activity.
Comments
Comment #1
MerryHamster commentedComment #2
MerryHamster commentedComment #3
maximpodorov commentedMaybe some wordings corrections are necessary:
"a relationship"
"Parent comment" - to indicate that the result of the relationship is comment, not node. The same change should be made elsewhere.
Comment #4
MerryHamster commentedОк, I added changes.
Comment #5
MerryHamster commentedComment #6
maximpodorov commentedIt works and looks reasonable.
Comment #7
damienmckennaComment #8
japerryWhy have a blank settings form? This is a feature request also, not a bug.
Comment #9
damienmckenna@japerry: You need a blank settings form function otherwise the Panels UI won't give you the settings item in the context menu.
Comment #10
damienmckenna.. though after looking at the others in plugins/relationships I'm not sure it's needed.
Comment #11
damienmckennaThis patch removes the empty settings form.
Comment #12
maximpodorov commentedNo, no. You removed the form but left the reference in $plugin array.
Comment #13
maximpodorov commentedRequirements for forms are so various across the different plugin types!
Comment #14
damienmckennaAh, thanks for noticing that.
Comment #15
damienmckennaMoving this to the v7.x-1.10 release plan.
Comment #16
maximpodorov commentedI renamed your patch to have more descriptive name.
Comment #17
damienmckennaThis didn't get added to 7.x-1.10.
Comment #18
chris matthews commentedThe 3 year old patch in #16 to comment_parent.inc applied cleanly to the latest ctools 7.x-1.x-dev and if still relevant needs to be added to the #2984057: Plan for CTools 7.x-1.15 release.
Comment #19
joelpittetComment #20
joelpittetIf someone following this and is using the patch can RTBC this, I'll add it in the next release.
Comment #21
andrey.troeglazov commentedI will check it.
Comment #22
rivimey@andrey ... bump?
Comment #23
joelpittetComment #24
joelpittetBump too, still looking for an RTBC from someone using this feature
Comment #25
joelpittetComment #26
joelpittetI'll trust it works, thanks @DamienMcKenna, @MerryHamster, et al, I've committed this to the dev branch for 1.18 release.