Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#16 | ctools-comment_parent-2506259-16.patch | 1.17 KB | maximpodorov |
Comments
Comment #1
MerryHamster CreditAttribution: MerryHamster commentedComment #2
MerryHamster CreditAttribution: MerryHamster commentedComment #3
maximpodorov CreditAttribution: maximpodorov commentedMaybe some wordings corrections are necessary:
"a relationship"
"Parent comment" - to indicate that the result of the relationship is comment, not node. The same change should be made elsewhere.
Comment #4
MerryHamster CreditAttribution: MerryHamster commentedОк, I added changes.
Comment #5
MerryHamster CreditAttribution: MerryHamster commentedComment #6
maximpodorov CreditAttribution: maximpodorov commentedIt works and looks reasonable.
Comment #7
DamienMcKennaComment #8
japerryWhy have a blank settings form? This is a feature request also, not a bug.
Comment #9
DamienMcKenna@japerry: You need a blank settings form function otherwise the Panels UI won't give you the settings item in the context menu.
Comment #10
DamienMcKenna.. though after looking at the others in plugins/relationships I'm not sure it's needed.
Comment #11
DamienMcKennaThis patch removes the empty settings form.
Comment #12
maximpodorov CreditAttribution: maximpodorov commentedNo, no. You removed the form but left the reference in $plugin array.
Comment #13
maximpodorov CreditAttribution: maximpodorov commentedRequirements for forms are so various across the different plugin types!
Comment #14
DamienMcKennaAh, thanks for noticing that.
Comment #15
DamienMcKennaMoving this to the v7.x-1.10 release plan.
Comment #16
maximpodorov CreditAttribution: maximpodorov commentedI renamed your patch to have more descriptive name.
Comment #17
DamienMcKennaThis didn't get added to 7.x-1.10.
Comment #18
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 3 year old patch in #16 to comment_parent.inc applied cleanly to the latest ctools 7.x-1.x-dev and if still relevant needs to be added to the #2984057: Plan for CTools 7.x-1.15 release.
Comment #19
joelpittetComment #20
joelpittetIf someone following this and is using the patch can RTBC this, I'll add it in the next release.
Comment #21
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedI will check it.
Comment #22
rivimey@andrey ... bump?
Comment #23
joelpittetComment #24
joelpittetBump too, still looking for an RTBC from someone using this feature
Comment #25
joelpittetComment #26
joelpittetI'll trust it works, thanks @DamienMcKenna, @MerryHamster, et al, I've committed this to the dev branch for 1.18 release.