Inject render service into LinkGenerator instead of calling drupal_render

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY000]: General error: 13 database or disk is full' in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/StatementPrefetch.php:175

Working on the test.

This is a performance boost too, less calls to the static

I applied the patch, and looked at the patch in PhpStorm. I had a question about injected service into the LinkGenerator constructor and pwolanin said it's not considered as an API change and it wont break BC.
#9 stated that it would improve performance so I am doing next. I will post performance result shortly.

I applied the patch, and looked at the patch in PhpStorm. I had a question about injected service into the LinkGenerator constructor and pwolanin said it's not considered as an API change and it wont break BC.

At some point we need to talk about that. Its worth to see the talk fabpot about the deprecation note, its never as easy as you think.

For now though, this is certainly the right thing to do, especially given how you would override the link generator.

A bunch of nits. I'd feel bad for un-RTBC'ing it, but the beta evaluation is missing here too. Plus, it's an easy fix.

1. +++ b/core/lib/Drupal/Core/Utility/LinkGenerator.php
   @@ -37,16 +38,26 @@ class LinkGenerator implements LinkGeneratorInterface {
   +   * The render service.
   ...
   +   *   The render service.
   
   +++ b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
   @@ -43,6 +43,14 @@ class LinkGeneratorTest extends UnitTestCase {
   +   * The mocked render service.
   

   Nit: we usually write "The renderer."

2. +++ b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
   @@ -43,6 +43,14 @@ class LinkGeneratorTest extends UnitTestCase {
   +   * @var \PHPUnit_Framework_MockObject_MockObject|\Drupal\Core\Render\RendererInterface
   +   *
   +   */
   

   Nit: The middle line can be deleted.

You can omit the "service" but, but that'd be okay too.

Now let's add the beta evaluation still.

Let's get it in, we have all we need.

So, #2393329: Replace all drupal_render calls with the service, and inject it, if possible. was postponed to 8.1.x, and we also agreed there to make all these changes in one single patch rather than in dozens of small issues. It'd be good going forward to keep in mind the recommendation made on the parent issue, and also note the part of the beta policy prioritized changes that says:

code already marked for removal by 8.0.0

(Emphasis added.)

drupal_render() is deprecated for 9.0.0.

However, since this keeps coming up with regard to drupal_render() in particular, I discussed this more with @Wim Leers and @berdir to understand the importance. @Wim Leers said that replacing a use of the static service call (which drupal_render() wraps) with an injected service does actually make a noteworthy performance difference relative to that bit of code, and since LinkGenerator is very much in the critical path, this issue in partiular is worth treating as a performance improvement.

In general, however, replacing code deprecated for 9.x is not a prioritized change during the beta, nor is general refactoring for dependency injection. Please help communicate this on other issues that you see in the queue along those lines.

So this patch individually is a good improvement during the beta. I'll follow up more on #2393329: Replace all drupal_render calls with the service, and inject it, if possible. (basically, replacing it with an injected service in frequently used code is worthwhile, but simply converting the procedural call to a static method call isn't really in scope for the beta). Thanks everyone for your work here! Committed and pushed to 8.0.x.

(Note that I reverted and re-committed this to add proper reviewer credit.)