It seems that the token prompt in the admin form for pm_email_notify never got ported to D7, so has all the wrong tokens, and even formapi syntax that doesn't work on D7.

Here's a patch to fix it.

CommentFileSizeAuthor
privatemsg.pm_email_notify_token_prompt.patch1.49 KBrfay

Comments

Status: Needs review » Needs work

The last submitted patch, privatemsg.pm_email_notify_token_prompt.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

None of the fails here are a result of this patch; I guess privatemsg testing is broken.

Status: Needs work » Needs review

rfay queued privatemsg.pm_email_notify_token_prompt.patch for re-testing.

dgtlmoon queued privatemsg.pm_email_notify_token_prompt.patch for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Looks fine, any chance you can throw in a module_exists and if so, add the token browser instead of the hardcoded examples? Preferable with #dialog => TRUE.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@Berdir, it already did that, which is probably why this went undiscovered. If Token module is enabled, it works great, with the browser.

  • Berdir committed dcee6e0 on 7.x-1.x authored by rfay 
    Issue #2505403 by rfay: Help prompt for tokens on pm_email_notify not...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed

Ah of course, we're already inside an else. Committed to 7.x-1.x and 7.x-2.x, with a small change.

  • Berdir committed 2664b9c on 7.x-2.x authored by rfay 
    Issue #2505403 by rfay: Help prompt for tokens on pm_email_notify not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.