Not sure if what I found could refer to this issue but I noticed that if a new Space/Section is created and Comments are enabled (for those content types) then if, at later time, Comments are going to be disabled for Space and/or Section, those Space/Sections yet created will continue to show the "Add Comment" functionality on their "landing" pages (and Comments can be effectively added to those pages if users have permissions to do so).
Disabling Comments for Space and/or Section has the side effect only to hide the Comment Open/Close settings which can normally be found while editing them: that's clearly not the expected behaviour because to hide the "Add Comment" a workaround should be then executed on each Space/Section.

IMHO an expected site behaviour would be: Disabling Comment for Space and/or Section content types should then disable (read: eventually "hide" not delete) any OA Comment (yet posted) from any Space and/or any Section and consequently also hide the Comment settings when editing those content types.

On the other hand, with Comments disabled, new Space/Section hasn't the "Add Comment" functionality and no Comment Open/Close settings could be found when editing them: that's right and expected.

A workaround to remove Comment functionality is to temporarily re-enable Comment for Space and/or Section (I focused on those two but, maybe, the procedure could also be valid for other content types) and then edit each content type to set "Close" on Comment Options then, finally, disable Comment for those content types.

Re-enabling Comment for Space/Section only shows what was hidden before (Comment Options) so those two options could be set accordingly (to open/close Comment feature).

A side note: personally - so undoubtedly my fault - I didn't understood what exactly "Paragraphs field" parameter really means ("Disabling this will remove the field from the comments for this type and loose any data in those fields."), maybe that - once disabled - Comments are really deleted (so lost) and not only simply hidden.

Anyone noted that?

Comments

mpotter’s picture

I believe this is just the normal way Drupal comments work. Changing the property in the Content Type only applies to NEW nodes. Each node has it's own Comment Enable/Disable setting.

So if you have comments on a space and then disable it for the content type, the comments for that space will still show until you specifically edit that space and Close the comments there.

If you want to hide all comments for spaces then you probably should disable the Comments and Comment Form panels widgets in your Space or Section layout templates.

But I have no plans to change default Drupal behavior. Disabling comments in the content type should NOT effect existing content.

"Paragraph Fields" are those tabs at the bottom of comments for Related Content, Media Gallery, Snippet, Text. Those are the default bundles for Paragraphs that can be added to both Comments and to node Body fields.

dpoletto’s picture

Issue summary: View changes
dpoletto’s picture

Yes but if I disable Comment on a Space/Section that had comments it's OK for me to not remove them...but, at least, this should led to a situation in which, no matter if the content type we're speaking about is new or old (in relation with the Comment enabling/disabling), no new comments should be posted (so the "Add Comment..." feature should go away while posted comment stay visible).

Isn't it?

This is particularly visible when you continue to see the "Add Comment..." functionality when no previous comment have ever been placed (no one practically want to comment a Space/Sections landing page, at least this is what I think now...I saw users commenting other content types very frequently but no landing pages) AND you disabled (at later time) Space/Section Comment.

mpotter’s picture

The problem is that on the Node, the only options for Comments are Open vs Closed. There isn't a "Hidden" option on the node like there is for the content type. As long as the node is "Open" you can post comments. So again, you need to edit the space and set comments to Closed to prevent new comments (and remove the Add Comment box).

Nothing is going to automatically loop through all of your spaces and set comments to Closed. You'd need to write custom code to do that. Or maybe there is some other Drupal Module that will go through and close all nodes of a specific content type. But that's outside the scope of Atrium.

dpoletto’s picture

OK, understood (Node vs content type difference we we're speaking about comments)...at least there is a sort of manual workaround. Thanks Mike!

hefox’s picture

Hidden exists per node, but only shows if the content has comments (changed from d6 when all three options always showed): https://api.drupal.org/api/drupal/modules%21comment%21comment.module/fun... Not sure if we're editing that out anywhere.

It sounds like a bug is that we're hiding ability to switch off comments when comments are disabled for a content type on content that has comments enabled.

hefox’s picture

Status: Active » Fixed

changed it so

1) comment setting form will appear if open (or closed with visible comments), so user can switch it to hidden (and after that, comment form will not appear unless re-eanbled for content type)
3) removed the comments and comment form pane when comments are set to hidden as it doesn't respect that setting, filed #2505395: When using "Comments and comment form" to display comments. node comment setting hidden is not respected to see if anyone wants to make a more generic solution

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.