Some libraries (like fluidvids and fitvids) can target an iframe class to make the video responsive. Any thoughts on adding a default class?

CommentFileSizeAuthor
#6 iframe_class-2504641-6.patch741 bytesjoelpittet
#1 video_embed_field-iframe_class-2504641-1.patch890 bytesemmonsaz

Comments

emmonsaz’s picture

emmonsaz commented
StatusFileSize
new video_embed_field-iframe_class-2504641-1.patch890 bytes

example

  • plopesc committed 7b9adde on 7.x-2.x 
    Issue #2504641 by emmonsaz, plopesc: Add iframe class support
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Fixed

Hello,

I added support for iframe CSS classes as a new config para meter for the video handlers. So if you want to add any class to the iframe, you only have to go to yoursite.com/admin/config/media/vef_video_styles and fill the CSS textfield with the classes you want to add to the iframe.

Regards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Closed (fixed) » Needs work

@plopesc the commit has a bug:

-    $embed = '<object id="myExperience" class="BrightcoveExperience">
+    $embed = '<object class="@class" id="myExperience" class="BrightcoveExperience">

Duplicate class attributes will cause some issues with rendering (which class attribute to use) and HTML validation.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-2.0-beta10 » 7.x-2.x-dev
Status: Needs work » Needs review
Issue tags: +Quick fix
StatusFileSize
new iframe_class-2504641-6.patch741 bytes

Here's a quick fix patch.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Fixed
Issue tags: -Quick fix

Thanks @joelpittet!

Should be fixed now.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

You're welcome glad to help

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.