Follow-up to #2232861: Create BrowserTestBase for web-testing on top of Mink

Problem/Motivation

Contrib unable to test functional test on d.o. see #2469609-3: Convert all WebTestBase to BrowserTestBase

Proposed resolution

Either BrowserTestBase needs a fix or infra has to update the contirb testing.

Remaining tasks

Unknown

User interface changes

None

API changes

Unknown

Comments

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I'm not sure where to post the issue so posted it in core issue queue can be moved to testbot queue.

dawehner’s picture

dawehner
Primary language German
commented

Unable to install modules entity_reference, field_ui, dynamic_entity_reference, entity_test due to missing modules dynamic_entity_reference.

Interesting, 

    $class = get_class($this);
    $modules = array();
    while ($class) {
      if (property_exists($class, 'modules')) {
        $modules = array_merge($modules, $class::$modules);
      }
      $class = get_parent_class($class);
    }
    if ($modules) {
      $modules = array_unique($modules);
      $success = $container->get('module_installer')->install($modules, TRUE);

seems not special ...

dawehner’s picture

dawehner
Primary language German
commented

Is this still true? Note: KernelTestBaseTNG actually works for contrib

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I have uploaded the patch on #2469609-29: Convert all WebTestBase to BrowserTestBase to test this again but I don't think it is fixed yet.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Contrib can't test Functional tests » Contrib can't run Functional tests
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

This problem still exists see https://qa.drupal.org/pifr/test/1143123

catch’s picture

catch
he/him
Primary language English
commented

The fail on DrupalCI is different though - so is this only a PIFR issue?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Yup only PIFR issue.

catch’s picture

catch
he/him
Primary language English
commented
Project: Drupal core » Drupal.org Testbots
Version: 8.0.x-dev »
Component: simpletest.module » Code

Moving to that queue then.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

As pifr is gone now should we close this as won't fix now?

bojanz’s picture

bojanz commented
Status: Active » Closed (won't fix)

Sounds like a yes.