Allow more file extensions to be uploaded using create_raw

besides mov file, other video formats will be required for typical use cases e.g. mp4

Added support for mp4 in the patch.

I think just adding variable_get and placing the default values instead of NULL, will either not solve the problem, as the variable would never be set for existing sites. So we can first check if variable_get gives us the extension, else we set it in our code itself, so that the users having existing sites can still edit the extensions list. Also we can keep the hook enable for new installations. Please suggest.

Hi, thanks for the work/patches that's already been done here.
Setting the allowed extension as file validator when calling file_save_upload().
This actually has been done in the patch #5 (manually entered file extension instead using a variable), but did not make it into patch #6.
This patch is basically a combination of #5 + #6; hence all the credits goes to bohemel and rasikap.

Oops, patch before (#11) was quite a bit off. Here goes again.

+++ b/resources/file_resource.inc
@@ -421,8 +426,8 @@
+  $extensions = variable_get('services_allowed_extensions', $default = NULL);

+++ b/resources/file_resource.inc
@@ -205,7 +205,12 @@
+    if ($extensions = variable_get('services_allowed_extensions', NULL)) {

Why not just

$extensions = variable_get('services_allowed_extensions', 'jpg jpeg gif png txt doc xls pdf ppt pps odt ods odp');

And

if ($extensions = variable_get('services_allowed_extensions', 'jpg jpeg gif png txt doc xls pdf ppt pps odt dos odp'))

Otherwise we need an update hook to set the variable as well.

Right you are. There you go.

Works great here.

Looks good, thank you everyone.

Is there any example of create_raw api ?

Here's a Drupal Services File Create Raw example courtesy of @Chipie that works with PhoneGap/Cordova: https://gist.github.com/signalpoint/8a0dc14c9553552a046a97abe9f2e48c

I'm confused. Comment #18 seems to indicate that this change was committed on July 6, 2016 13:32 (https://www.drupal.org/commitlog/commit/2634/eaf572c47e38b13fa37e25c9b2a61bf54209ab07). The issue was marked as "fixed" and a new release 7.x-3.16 came out on August 1, 2016 (about 3 weeks after the commit). I just upgraded and the changes found in comment #15 (https://www.drupal.org/files/issues/services-allowed_extensions_in_file_create_raw-2502281-15-d7.patch) are not present in the release. Am I misunderstanding something here?

I'm re-opening this since the fix hasn't actually been released. I'm changing the status back to RTBC to make sure that this issue isn't neglected and mistaken as "fixed" in case something has gotten borked during the release procedure. I'd appreciate an update to understand why this hasn't been released as expected. Then once we understand why, we can mark this back as "fixed".

Hmmm, this also happened here: https://www.drupal.org/node/2472757#comment-11517375

@kylebrowning, any idea what why a few commits didn't make it into the latest release? https://www.drupal.org/project/services/releases/7.x-3.16

Thanks for looking into this, @tyler.frankenstein. I was also just wondering if it was something I was misunderstanding. But since you've found another instance, I guess it's not just me! :-) Hopefully it's not something systemic that will cause headaches for maintainers.

Yeah, I made a mistake with the tag. 3.17 coming out shortly.

Thank you!

Hello All, I had some problems with extensions.
I need to use '.zip' and '.7z', but I have '_.txt' and '.txt'.
Maybe we can use a page with a form in admin to manually update the list with extensions