Fatal error: Call to undefined function drush_commerce_stripe_download() in /sites/all/modules/commerce_stripe/commerce_stripe.drush.inc on line 55
Drush command terminated abnormally due to an unrecoverable error.
Error: Call to undefined function drush_commerce_stripe_download() in
/sites/all/modules/commerce_stripe/commerce_stripe.drush.inc,
line 55

Error in code, drush_commerce_stripe_download() does not exist. It is being called on line 55.

The function it's looking for is there, just misnamed drush_commerce_stripe_stripe_download()
Depends on which naming convention we are looking for, but one of them needs to change, either the declaration or the implementation.

Comments

VanD’s picture

StatusFileSize
new2.87 KB

Here is a patch renaming the declaration. It was also missing an ending parenthesis.

VanD’s picture

StatusFileSize
new2.8 KB

Here is a secondary patch doing essentially the same thing, but renaming the implementation instead of the declaration

VanD’s picture

Status: Active » Needs review
VanD’s picture

StatusFileSize
new2.8 KB

Sorry, I actually screwed up those last patches.

Here is the updated version

aviindub’s picture

Status: Needs review » Fixed

this patch contains a bunch of irrelevant changes. the error was simply caused by the extra {, which remains in your patch. therefore, not going to patch this. the error should be resolved now, let me know if not.

mesch’s picture

Status: Fixed » Needs review
StatusFileSize
new409 bytes

@aviindub, I was able to replicate this this morning against HEAD. To replicate, try installing via drush (e.g. drush en -y commerce_stripe, and you will get the fatal call for function drush_commerce_stripe_download, which doesn't exist.

Patch attached that fixes this.

aviindub’s picture

Status: Needs review » Fixed

maybe this was just an accident of timing, but you did not do that off the latest HEAD. that change is already present on the current 7.x-1.x. if you update your repo and still do not see that change, please let me know, because that would mean something really weird is going on. in my copy of the repo, that change is already made and committed and my repo is in sync with the remote.

mesch’s picture

Hmmm... odd. I did pull a few times when I looked at this over the weekend. I pulled just now and got all the commits you made today (since a2de13f). Oh well, this issue no longer matters anyways since #2501613: Remove Automatic Git Clone of Stripe Library When Enabling Module Via Drush was committed. Thanks BTW for turning these around so quickly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.