Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2458003: Port MigrateSourceCSV to Drupal 8 migrate source plugin
MigrateSourceXML should be a plugin for migrate that extends the migrate base classes for migrate source.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2500955-3.patch | 24.69 KB | mbaynton |
#3 | 2500955-2-3.interdiff.txt | 23.33 KB | mbaynton |
#2 | 2500955-2.patch | 17.91 KB | mbaynton |
Comments
Comment #1
mikeryanComment #2
mbayntonComment #3
mbayntonNew functionality (primarily allowing certain elements that have been registered ahead of time to be referenced in xpath-like epxressions as parents of the context node) and lots of Drupal CS revisions.
This code and my work on a wordpress_migrate for D8 have now been used as parts of a successful site migration.
Comment #4
heddnLet's see what happens with tests.
Comment #5
mbayntonI need to post/update the wordpress_migrate for D8 module I used, this is rather opaque without it...
Comment #6
mbayntonOk that's at https://github.com/mbaynton/wordpress_migrate
Comment #7
mikeryan@mbaynton - Just wanted to say I don't mean to ignore you, the XML source plugin and wordpress_migrate are important for D8 - at the moment, though, the top priorities are the core migration framework and the D6/D7 upgrade paths, so I haven't had time to give this the detailed review it deserves. That will come, but not immediately.
Thanks for your work on this.
Comment #8
mbaynton@mikeryan Sure. Thanks for the update.
Comment #9
mikeryanFinally ready to dig into this by using it in #2609284: Add XML migrations to wine example.
But, much like different field types like text and link have different modules, I'd like to see this go into a separate module/project. @mbaynton, unless you'd like to create the d.o project migrate_source_xml for this, I'll go ahead and do it myself - I'd be happy to add you as a co-maintainer with your permission.
Comment #10
heddnWould this be a sub-module of migrate_plus, similar to CSV or separate? And if separate, could we get CSV split out as well?
Comment #11
mikeryanYes, separate - and I would like to separate migrate_source_csv out too. I'm trying to think about the logistics of that for existing migrate_source_csv users - removing it from migrate_plus at the same time will obviously break them, but keeping it there and deprecated for a transition period would be problematic in terms of having the same module name twice...
Comment #12
mbaynton@mikeryan yes please go ahead with the d.o project. I'm on vacation so would be awhile for me to do it. You can add me as co-maintainer. Thanks!
Comment #13
mikeryanDone! You are the co-maintainer of https://www.drupal.org/project/migrate_source_xml, and I've committed your initial patch.