Closed (works as designed)
Project:
Token Insert Entity
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2015 at 19:36 UTC
Updated:
29 Feb 2016 at 10:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jcnventuraUpdate for v1.1
Comment #2
johnpitcairn commentedWhile it may work for you, is a clone appropriate here? The entity being rendered should be the same entity throughout the lifetime of the page, there shouldn't be a cloned copy hanging around. There is a
drupal_alter()call fromnode_view(), thenhook_field_attach_view_alter()runs, etc, and modules may have implemented earlier hooks, expecting to be altering the same entity each time, who knows what they may try to do? That clone makes me nervous.There is a bug filed against node.module: #2385683: Ensure node content is an array before concatenating attached fields which proposes a clone. I have proposed a far more simple solution there.
Comment #3
johnpitcairn commentedComment #4
johnpitcairn commented@axe312: The patch against core in the related issue may work for you?
My thinking here is that this is not token_insert_entity's bug, it should be fixed in node module.