See http://lolandese.altervista.org/flickr/1/tag/kids.

Instead http://lolandese.altervista.org/flickr/1/tags/kids gives the desired result. Note the added 's' in the URL.

CommentFileSizeAuthor
#3 wrong_image_links_in_tag_list-2498821-3.patch896 byteslolandese
#1 wrong_image_links_in_tag_list-2498821-1.patch411 byteslolandese

Comments

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new wrong_image_links_in_tag_list-2498821-1.patch411 bytes
sumitmadan’s picture

sumitmadan commented

I think for a single tag the url should be "flickr/1/tag/kids" without 's'.

lolandese’s picture

lolandese commented
StatusFileSize
new wrong_image_links_in_tag_list-2498821-3.patch896 bytes

Right. Clear cache after applying the new patch.

sumitmadan’s picture

sumitmadan commented
Status: Needs review » Fixed

  • sumitmadan committed c37496d on 7.x-1.x 
    Issue #2498821 by lolandese: Wrong images for tag list links
lolandese’s picture

lolandese commented

Just as a side note:

For me it's not a big deal, you can leave it as it is. However if others supply patches in the issue queue and they get committed (even if you make some minor corrections), make sure to use the suggested --author flag to give them attribution.

Personally I always give them attribution if they helped to find the solution, even if I wrote the patch. It makes it more stimulating for people to contribute also the next time.

Thanks.

sumitmadan’s picture

sumitmadan commented

Sure. I'll keep in mind. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.