The path to Advanced Help in hook_help() of submodule Views Slideshow: Cycle is no longer valid.

The reason for this is a change in Advanced help as described in the release note for Advanced help 7.x-1.3.

Do not install this patch if you're running a version of Advanced Help older than 7.x-1.3 - unless you also update Advanced Help to the latest version.

CommentFileSizeAuthor
#1 views_slideshow-path-for-advanced-help-must-be-updated-2497785-1.patch1.02 KBgisle

Comments

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
StatusFileSize
new views_slideshow-path-for-advanced-help-must-be-updated-2497785-1.patch1.02 KB

Here is the patch.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

Any problem with that if using an old version of AH? (should it test the module version and only change the path if sufficiently new?)

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Any problem with that if using an old version of AH?

Yes. If you applied the patch and were using an old version of AH, AH would no longer work with VSC.

This patch is for site owners who prefer to run the latest stable release of everything they use - not for site owners whose philosophy is to leave things unchanged as long as nothing is broken. (I know that both types of site owners exist.)

(should it test the module version and only change the path if sufficiently new?)

IMHO, no.

Why should somebody running a pre-7.x-1.3 version of AH apply this patch? If it ain't broken, don't fix it.

Further: Having code that sniff for versions and take different action depending on version bloats the module and is harder to maintain. It may only be 3 or 4 extra lines to this 1 line patch. But things adds up and if this becomes common practice Drupal will be even more bloated than it already is.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue summary: View changes

Updated issue summary with a caution about not updating if an outdated version of AH is installed.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Reviewed & tested by the community

yeah, that's what I was guessing.
well been close to 9 months since that version of AH was initially released so I think it should just go in and have it in the release notes that updating AH is required.
(and yeah version checking does add yuck to an otherwise really simple/clean patch)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: views_slideshow-path-for-advanced-help-must-be-updated-2497785-1.patch, failed testing.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Reviewed & tested by the community

  • vbouchet committed a54f7d1 on 7.x-3.x authored by gisle 
    Issue #2497785 by gisle: The path for advanced help in submodule Views...
vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Reviewed & tested by the community » Fixed

The path has been updated. Thanks for the patch ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.