The theme can remove some CSS files from other modules. E.g. Zen removes three CSS files:
stylesheets[all][] = system.menus.css
stylesheets[all][] = system.messages.css
stylesheets[all][] = system.theme.css

WYSIWYG loads all CSS files defined by the theme including these files which does not exist in theme. File existence should be checked before adding CSS files to the editor.

CommentFileSizeAuthor
#1 wysiwyg-check_css_existence-2496419-1.patch523 bytesmaximpodorov

Comments

maximpodorov’s picture

maximpodorov commented
Status: Active » Needs review
Related issues: +#1793704: Fully process local CSS file paths, +#2289623: 404 (Not Found) system.menus.css within CK Editor iframe
StatusFileSize
new wysiwyg-check_css_existence-2496419-1.patch523 bytes
twod’s picture

twod
Primary language Swedish
Location Sweden
commented

Cool, thanks for the patch! I'll test it together with a bunch of other changes I have planned for dealing with stylesheets later, working on a few other things right now.

Does this work when CSS aggregation is enabled as well?

maximpodorov’s picture

maximpodorov commented

Yes, this should work with aggregation. The core performs the same checks:
http://cgit.drupalcode.org/drupal/tree/includes/common.inc?h=7.x#n3613
http://cgit.drupalcode.org/drupal/tree/includes/common.inc?h=7.x#n3485

elpino’s picture

elpino commented
Issue tags: +Worked for me with CSS aggregation enabled.
elpino’s picture

elpino commented
Issue tags: -Worked for me with CSS aggregation enabled.

Worked for me with CSS aggregation enabled.

*oops sorry for the issue tag, clicked on wrong text box

  • TwoD committed 2bedc7b on 7.x-2.x authored by maximpodorov 
    - #2496419 by maximpodorov, elpino: Fixed trying to load CSS files...
twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Needs review » Fixed

Great, thanks for the patch and the review!

Btw, maybe that should be a tag, considering all the problems aggregation used to cause hehe. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.