Enabling core's Testing module and navigating to admin/config/development/testing results in an exception: MissingGroupException: Missing @group annotation in Drupal\xmlsitemap\Tests\XmlSitemapEntityFunctionalTest (plus several other files).

CommentFileSizeAuthor
#5 2495523-fix-tests.patch18.12 KBdave reid
#4 2495523-fix-tests.patch16.39 KBdave reid
#1 2495523-1-group-annotation.patch6.49 KBmikeker

Comments

mikeker’s picture

mikeker commented
Status: Active » Needs review
StatusFileSize
new 2495523-1-group-annotation.patch6.49 KB

Adds @group annotations to all the non-base test files.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Reviewed & tested by the community

I wasn't able to reproduce the error but XMLSitemap didn't show up at all on the testing page and it does, now, with this patch. Tested against Drupal 8 Beta 10.

pguillard’s picture

pguillard commented

I confirm, enabling xmlsitemps prevents TestDiscovery to run.
RTBC++ !!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2495523-fix-tests.patch16.39 KB

This should also fix that setUp() is now protected, xmlsitemap enabling should be inherited, and getInfo() methods removed.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2495523-fix-tests.patch18.12 KB

With the sub-module tests included in changes now.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Went ahead and pushed the fixes up.

  • Dave Reid committed 8d99d83 on 8.x-1.x 
    Issue #2495523 by Dave Reid, mikeker: Converted test classes from...

The last submitted patch, 4: 2495523-fix-tests.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 5: 2495523-fix-tests.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 4: 2495523-fix-tests.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: 2495523-fix-tests.patch, failed testing.

mikeker’s picture

mikeker commented
Status: Needs work » Closed (fixed)

Silly testbot...