For each commit message:

  1. Find the username mentions. Best 3rd-party algorithm to use?
  2. Update issue node with credit reference.

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Priority: Normal » Major

Since the recent credits are now shown, bumping the priority.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented

https://github.com/lauriii/drupalcores/blob/master/app/bin/json.rb does this with ruby.
It also takes into account reverted issues, to prevent triple counting (commit, revert, commit)
And https://github.com/lauriii/drupalcores/blob/master/app/config/name_mappi... has the list of known mappings needed to fix mistakes made in commit messages or changed d.o names

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

There's also #443000: When viewing an issue, display a list of commits that reference that issue #. Version Control API already can record the issue/commit relationships, but we haven't had a chance to enable it in production.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +drupal.org contribution crediting
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Is the plan to only look at core issues or will the contrib issue histories also be parsed and contrib issue nodes be updated?

Also, how does this work with organizational attribution? I would like to retroactively assign attribution to Hook 42 for any work I've done since June 2012. I'm unclear how to do that. I did go back and update some comments and changed the attribution but then it changes the comment date so that looks funny. It would be great if we had a place we could retroactively assign attribution if we want to. I looked in the issue queue for Drupal.org customizations and didn't find anything related to that except perhaps this issue and the related issue:

#2042697: Add historical issue credits to Drupal.org user profile

Should I open an issue for assigning attribution to older issues?

Thanks!

joshuami’s picture

joshuami
he/him
Primary language English
Location Portland, OR
CreditAttribution: joshuami at Drupal Association commented

If we parse commit credits into issue credits, then we would do so for all projects hosted on Drupal.org.

The current use of issue credits on Drupal.org is to highlight current involvement by users and organizations (last 90 days). We could expand this, but there will always we a cutoff point that leaves out some historical credit that probably should have been awarded.

Until we know when we can get back around to another round of org and user profiles, I wouldn't spend the time applying issue credits to past issues. That seems like a lot of work and it would require editing a lot of history. If we import the commit credits that will be more accurate historically.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

See below:

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

I realised this is not the issue I was looking for. I don't think that issue exists, so opened #2676042: Automatically assign issue credit for committing patches.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

This was related to a recent discussion in Slack about issue credits vs commit mentions related to:

#3129394: Add list of Drupal 9 core contributors with number of issues credited

Not sure this one is still being considered as it's last comment was 4 years ago! I'm going through my old issues now to unfollow/etc.