Notice : Undefined variable: element in entityreference_field_formatter_settings_form() (line 1141 in /sites/all/modules/entityreference/entityreference.module). [#2495405]

When Entity Reference is interacting with different modules, can produce the following error:

Notice : Undefined variable: element in entityreference_field_formatter_settings_form() (line 1141 in /sites/all/modules/entityreference/entityreference.module).

I found it is given because $element is display type is none of the expected ones. I have added a simple check to avoid returning $element if not set.

Comment	File	Size	Author
#8	entityreference-2495405-2.patch	526 bytes	jenlampton
#6	entityreference-undefined_variable-2495405-6.patch	566 bytes	jenlampton
#2	entityreference-2495405-2.patch	526 bytes	geoffreyr
	entityreference_2314339.patch	243 bytes	dtamajon

Comments

Comment #1

geoffreyr commented 13 July 2015 at 06:46

This seems to be triggered when selecting Entity ID as the display type. Currently noticing this while I try and Formatter Field working with Paragraphs - there's no initialisation for $element taking place in this function.

Comment #2

geoffreyr commented 13 July 2015 at 08:21

Status:

Active

» Needs review

Status	File	Size
new	entityreference-2495405-2.patch	526 bytes

Here's a really tiny patch that should address the issue.

Comment #3

damienmckenna

TN, USA

commented 13 July 2015 at 12:30

Parent issue:

» #2532152: Plan for EntityReference 7.x-1.2 release

Comment #4

devin carlson commented 27 August 2015 at 07:46

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Needs review	» Reviewed & tested by the community

This is very easy to run into while using the Entity Embed module.

The one-line patch in #2 applies cleanly to Entity Reference 7.x-1.x and ensures that $element is always defined. This is the same approach taken by the example implementation of hook_field_formatter_settings_form() in field_ui.api.php.