Closed (fixed)
Project:
Fieldable Panels Panes (FPP)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 May 2015 at 11:46 UTC
Updated:
4 May 2018 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaCould you please review other entities (e.g node) to confirm what they look for in order to display the language selector? Thanks.
Comment #2
upchuk commentedSo basically the node module does nothing, but the Locale module does it for the node.
When locale is enabled, you can have multiple languages. If you edit a node type and enable multilingual on it, the form_alter kicks in on the nodes of that type and the language selector gets printed:
I suppose we could replicate this by enabling multilingual on individual FPP bundles but this is up to you guys. It's not difficult either, we just need to add the same multilingual selector on the bundle edit form (
admin/structure/fieldable-panels-panes/fieldable_panels_pane/edit) and save it to a variable (exactly like locale does for node types). Then we apply based on that either directly a language value or a selector. Let me know if you wanna do this. (Also keep in mind whatlocale_field_node_form_submit()does)Based on my finding, I cleaned up a bit the language selector:
Comment #3
damienmckennaComment #4
damienmckennaApologies for the delay in getting to this.
This issue needs a tests to confirm that at least the edit form works as intended. Also, the methods need docblock comments.
Comment #5
damienmckennaComment #6
damienmckennaThis adds some tests.
Comment #7
damienmckennaCommitted. Thanks!
Comment #10
AgentJay commentedThis doesn't seem to work correctly. When I create an FPP entity and select a language I can't go back and edit that entity. It seems to be saving the entity with the default 'language neutral' language option.
Comment #11
AgentJay commentedIt works fine for newly created FPP entities. It's only ones that were already created before this update that have an issue.
Comment #12
betz commentedI can conform this bug.
I had to upgrade an old panopoly distro, and all my existing panel pages with FPP on it have empty fields.
Doing the upgrade again, but locking the upgrade with FPP v1.8 worked fine.
Comment #13
damienmckennaPlease open a new issue for follow-on problems. Thank you.
Comment #14
betz commented❤️