Problem/Motivation

captcha.install has a couple of $form_ids currently, some aren't used anymore and should be removed.
Currently:

    'contact_site_form',
    'contact_personal_form',
    'user_register_form',
    'user_pass',
    'user_login_form',
    'user_login_block',
    'forum_node_form',

Proposed resolution

Remove unnecessary form_ids

Remaining tasks

Discuss which form_ids aren't used anymore (e.g. user_login_block), remove the ones that are superflous, and commit a patch.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 ensure_the_form_ids-2493593-3.patch811 bytessumitmadan

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: Task » Bug report

Not much to discuss :)

* user_login_block doesn't exist anymore

forum_node_form is now node_forum_form. The contact form ID's also changed, just go to /contact and the personal contact form at user/2/contact (you can't contact yourself) and update them.

elachlan’s picture

elachlan commented

Submit a patch and I'll review/update git.

sumitmadan’s picture

sumitmadan commented
Status: Active » Needs review
StatusFileSize
new ensure_the_form_ids-2493593-3.patch811 bytes

Changed the form ids according to new ones. :)

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community

Works fine

  • elachlan committed ef352b2 on 8.x-1.x authored by sumitmadan 
    Fixed Issue #2493593 by sumitmadan, LKS90, m1r1k: Ensure the form_ids...
elachlan’s picture

elachlan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 3: ensure_the_form_ids-2493593-3.patch, failed testing.

Status: Needs work » Needs review

isntall queued 3: ensure_the_form_ids-2493593-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: ensure_the_form_ids-2493593-3.patch, failed testing.

elachlan’s picture

elachlan commented
Status: Needs work » Closed (fixed)