Why clutter the admin menu? Move Advanced Help under Help

Thanks for the patch!

It is actually a very old feature request: #839382: Integrate with the Core Admin Help link - but your patch made it much more concrete.

This patch removes the link from the admin bar and where put it? By default the administration menu can't have submenus, so the menu disappear, right? or I'm doing something wrong?

But really like this idea.

Sorry, I wasn't talking about this module: https://www.drupal.org/project/admin_menu I was talking about the native admin menu, that one can have submenus?

Hi @MattWithoos.

I would like get feedback from gisle before to put it as RTBC but this looks good to me.

Some comments:

1. +++ b/advanced_help.module
   @@ -40,12 +40,39 @@ function advanced_help_menu() {
   +    // Add tabs to core Help page to access Advanced Help
   

   The comment should finish with a dot.

2. +++ b/advanced_help.module
   @@ -40,12 +40,39 @@ function advanced_help_menu() {
   +      'access callback' => true,
   

   We want to do this? I mean, with this even the non logged users will be able to access to this tab, right?

3. +++ b/advanced_help.module
   @@ -40,12 +40,39 @@ function advanced_help_menu() {
   +    // Determine whether to nest the Advanced Help menu link
   

   The comment should finish with a dot.

great work, thank you.

Thanks for the patch in #10.

The part that leverages on the contrib. Administration menu module to nest the Advanced Help menu link seems to work as intended.

However, the code that is supposed to add tabs to core Help page to access Advanced Help does not work on my test site. I would expect to see something like the mockup below:

But there are no tabs. And when Administration menu is not enabled, your patch has no effect.

I think when the administration menu module is not enabled the link should keep appearing in the admin menu, so I think what the patch does in this part is ok.

And on my side the tab appear but when I click it returns "access denied".

Another attempt of adding the mockup of how it should appear if Administration menu is not enabled:

I don't think "Advanced help" should be visible in the admin toolbar when it is accessible via a separate tab on the "Help" page. The general idea here is too avoid cluttering the admin toolbar, and this applies both when Administration menu is enabled, and when it is not enabled.

Removed mockup from summary.

Here is my take on uncluttering the admin toolbar.

It is based upon the mockup in #14 and does not leverage of the contrib Administration menu.

What it does is simply to remove the "Advanced menu" from the admin toolbar and makes it accessible via a tab inside "Help" (unless "Help" is disabled - then it appears on the admin toolbar).

I believe this implementation is what was requested in the original feature request: #839382: Integrate with the Core Admin Help link.

Please review.

Changing version. Patch in #16 must be applied against dev snapshot (0ce616 - it is currently the HEAD).

Just one thing

+++ b/advanced_help.module
@@ -247,11 +257,12 @@ function advanced_help_index_page($module = '') {
+        // $items[] = advanced_help_l($name, "admin/advanced_help/$module");

Can we delete this comment?

And this is RTBC to me.

Can we delete this comment?

I've deleted the comment and applied the patch.

Result is now in the latest snapshot of the 7.x-1.x branch.

Now we need port this to the D8 branch.