Validate that the unpublish date is later than the publish date

Corrected comment.

There was no automated test to check this validation, so I have added one to testValidationDuringEdit

✗	 testValidationDuringEdit
fail: [Other] Line 475 of modules/scheduler/src/Tests/SchedulerFunctionalTest.php:
Validation prevents entering an unpublish-on date which is earlier than the publish-on date.

As expected it currently fails.

Here's a re-rolled patch now that the constraint files are not new.

I was hoping to see testValidationDuringEdit all pass now but it does not, and we still have the same failure as before.

Can someone else test this patch? It works for me both interactive and in simpletest, so I do not understand why the test still fails on D.O. There was no error in applying the patch, at least I could not see any problem on https://dispatcher.drupalci.org/job/default/49316/console

Here's the same code change but with debug added. Hopefully this will indicate what might be happening on the DrupalCI which is different from my localhost.

That's no help, I can't see where the debug output is, or maybe we only get debug written from the actual test files, and it is ignored from the real Scheduler functions. Here's a patch with the first constraint commented out, just to check that we are actually applying this patch correctly, as so far none of the recent patch tests above have had any obvservable impact on the result.

Something must be going wrong with the testbot patch process, as this recent patch had the working constraint commented out but the test still passed, ie the validation message must have been displayed, as no fail was given (see attached A). It seems that the tests are all being executed on un-patched code.

Also there was some major failure in the second test file SchedulerDateCombinedFunctionalTest (image attached B) which implies something going wrong which is nothing to do with our patches.

I think I will have to leave this, as can't see what more I can do. I will re-test tomorrow, to see if something has been fixed in DrupalCI.

Same code as before, but re-rolled following recent commits. This should return all passes for testValidationDuringEdit() and overall we should get 10 classes pass and 6 fail.

That's good. Result as expected:

✓		- testValidationDuringEdit

10 class pass and 6 fail. Thanks Joe for the initial patch.