Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 4 problems (4 errors, 0 warnings)
Attached is the full list of errors found by ESLint and the patch that fixes them.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-8-12.txt | 820 bytes | sdstyles |
#12 | fix-eslint-errors-2490316-12.patch | 1.29 KB | sdstyles |
#8 | fix-eslint-errors-2490316-8.patch | 1.27 KB | sdstyles |
fix-eslint-errors.patch | 1.25 KB | rteijeiro | |
pathauto-eslint-output.txt | 319 bytes | rteijeiro |
Comments
Comment #2
nod_Don't know why the PHP fails but it's unrelated to this patch.
Comment #5
GrimreaperHello,
The test failed because the 8.x-1.x branch on Drupal.org is not functionnal see #2442425: install a contrib module error
The real pathauto 8.x-1.x is there https://github.com/md-systems/pathauto
And I just check your patch against the last code base and it is applyable and it fixes the ESLint errors.
Thanks for the patch Drupal heroes ;)
Comment #7
Dave ReidNeeds a re-roll.
Comment #8
sdstyles CreditAttribution: sdstyles at FFW commentedComment #11
juampynr CreditAttribution: juampynr at Lullabot commentedWhy context was removed here and in the next line?
I think that this is incorrect. It should be else if. Is ESLint changing this automatically?
Comment #12
sdstyles CreditAttribution: sdstyles at FFW commented@juampynr you are right this should be fixed, last time I just reroll the patch, now I fixed issues and re-checked script with eslint.
Comment #13
alexdmccabeIt looks like these changes were already applied as a part of #2683367.