Closed (fixed)
Project:
Scald: Media Management made easy
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 May 2015 at 12:43 UTC
Updated:
4 Jun 2015 at 10:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
HaiNguyen007 commentedComment #2
nagy.balint commentedHi!
It is a better idea to let the contexts define the width and height. Because 100% is not always the preferred outcome, sometimes you would like 50% or some other size.
We have done that already at some providers, look at scald_youtube for implementation at scald_youtube_scald_prerender.
Comment #3
gifad commentedAttached a patch inspired by scald_youtube implementation;
BTW, it should also be ported to scald_video...
Comment #4
nagy.balint commentedYes, and its not the only thing that should be ported to scald_video, but i guess that will be done after 1.4 release.
Comment #5
HaiNguyen007 commentedPatch in #3: will have error if user don't set height & width for atom in atom-edit-form:"
Notice: Undefined index: und trong scald_flash_scald_prerender()"
And flash atom can't fit 100% of its container when I set height=100% & width = 100% in context of flash provider.
Comment #6
HaiNguyen007 commentedI create this patch combine idea form patch #1 & patch #3 for scald flash support: custom height & width from context settings, and also support exactfit to container if custom height = 100%, & custom width = 100%.
Comment #7
HaiNguyen007 commentedComment #10
HaiNguyen007 commentedRe-roll patch minor fix
Comment #11
HaiNguyen007 commentedComment #12
nagy.balint commentedSeems you have changed the nested objects method to the twice cooked method.
I have read this http://alistapart.com/article/flashembedcagematch
And seems that the nested objects is the way to go with some additional conditional comments.
Because the twice cooked method is incorrect as embed is not w3c standard.
Also added code to display the default thumbnail of flash files when the thumbnail is not given.
Attached updated patch.
Comment #14
nagy.balint commentedThanks! Committed.