Problem/Motivation

I the age of reponsive design, I think people always want flash atom take full 100% width of its container. Not want to customize height & width of flash atom.
And also avoide when I custom height & width of flash atom, then scald display also weight & width to user (I don't want this)

Proposed resolution

I change template of flash atom render to exactfit & height=100% & width = 100%

Comments

HaiNguyen007’s picture

StatusFileSize
new1.48 KB
new173.79 KB
new147.09 KB
nagy.balint’s picture

Hi!

It is a better idea to let the contexts define the width and height. Because 100% is not always the preferred outcome, sometimes you would like 50% or some other size.

We have done that already at some providers, look at scald_youtube for implementation at scald_youtube_scald_prerender.

    if(isset($context_config->data['width'])){
      $video_width = $context_config->data['width'];
    }
    if(isset($context_config->data['height'])){
      $video_height = $context_config->data['height'];
    }
gifad’s picture

Status: Needs work » Needs review
StatusFileSize
new1.61 KB

Attached a patch inspired by scald_youtube implementation;

BTW, it should also be ported to scald_video...

nagy.balint’s picture

Yes, and its not the only thing that should be ported to scald_video, but i guess that will be done after 1.4 release.

HaiNguyen007’s picture

Status: Needs review » Needs work
StatusFileSize
new149.09 KB

Patch in #3: will have error if user don't set height & width for atom in atom-edit-form:"
Notice: Undefined index: und trong scald_flash_scald_prerender()"

And flash atom can't fit 100% of its container when I set height=100% & width = 100% in context of flash provider.

HaiNguyen007’s picture

I create this patch combine idea form patch #1 & patch #3 for scald flash support: custom height & width from context settings, and also support exactfit to container if custom height = 100%, & custom width = 100%.

HaiNguyen007’s picture

Status: Needs work » Needs review

The last submitted patch, 1: 2488594-scald-flash-auto-fit-container.patch, failed testing.

Status: Needs review » Needs work
HaiNguyen007’s picture

HaiNguyen007’s picture

Status: Needs work » Needs review
nagy.balint’s picture

Seems you have changed the nested objects method to the twice cooked method.

I have read this http://alistapart.com/article/flashembedcagematch
And seems that the nested objects is the way to go with some additional conditional comments.

Because the twice cooked method is incorrect as embed is not w3c standard.

Also added code to display the default thumbnail of flash files when the thumbnail is not given.

Attached updated patch.

nagy.balint’s picture

Status: Needs review » Fixed

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.