Current situation could do with some work:

Screenshot

CommentFileSizeAuthor
#1 2488464-shiny-date-contrib.patch1.14 KBsam152
#1 Screen Shot 2015-05-14 at 3.42.14 pm.png13.26 KBsam152
Screen Shot 2015-05-14 at 3.33.36 pm.png20.54 KBsam152

Comments

sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2015-05-14 at 3.42.14 pm.png13.26 KB
new 2488464-shiny-date-contrib.patch1.14 KB

After:

after

dudenhofer’s picture

dudenhofer commented
Status: Needs review » Needs work

First off, thanks for the patch. But there are a few things that I'm not sure of about this one. This is overriding classes like "date-no-float" from the date module... maybe this should be applied to the date module itself? Or figure out why there are no-float classes before we override them? Also, this only applies to the default date field type - do we want it to apply to the Unix timestamp and the ISO format? Also if the "Show end date" checkbox is enabled, it doesn't look so nice.

I'm not against this, just want to make sure it's not going to mess something else up, and we keep it consistent.