I'm seeing this issue locally with Workbench Moderation + Panels IPE + Panelizer

1. Enable the Workbench block and assign it to a region
2. Visit a Panelized, Moderated Node with Panels IPE enabled, and make edits to the layout/content with the IPE
3. Attempt to change the moderation status of the draft
4. Receive error as the form was built with a vid older than the new one generated by Panels IPE

The attached patch calls a utility function that will be provided in Workbench Moderation to refresh the Workbench block after finishing IPE edits.

I'm waiting on https://www.drupal.org/node/2485713 to close before putting this into review, which is the issue that adds the previously mentioned utility function. I'll keep this issue in the "Needs work" status until the Workbench Moderation issue is closed.

Comments

samuel.mortenson’s picture

StatusFileSize
new731 bytes
samuel.mortenson’s picture

StatusFileSize
new2.88 KB

redacted, wrong issue.

samuel.mortenson’s picture

saltednut’s picture

Status: Needs work » Needs review
saltednut’s picture

Status: Needs review » Needs work
Anonymous’s picture

We've been using the patch in conjunction with other workbench patches in production for 6+ months with no issue, so once those others are past "needs review" this can be RTBC.

damienmckenna’s picture

Should it do a slightly more elaborate check for Drupal.behaviors.workbenchModerationBlockRefresh first? What happens with that line in e.g. IE11 if Drupal.behaviors.workbenchModerationBlockRefresh doesn't exist?

Anonymous’s picture

Ah, I actually don't have the workbench block enabled so my comment probably isn't too valid for testing purposes :) But FWIW I agree that it should do some better checking for the function.