[D7] Content Type Search in Add Content(node/add) Page

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @kunal.maity.gmail,
Please commit the proper files to the git repository. More information is required in module_name.info file. There is no module_name.module file and why is the stp-search.tar.gz file required?

Thank you for your contribution, this can be done with a few contrib modules admin_views search_api and search_api_autocomplete; however, this is an out-box solution.

• Comment #5 is right, your module should not be compressed inside of the git. All your files should be in the root of your project.
• CSS and JS should have a more useful name , the name "custom" does not said anything. You should name your css file something like this stp_search.css or stp_search_autocomplete.css. And your JS should be something like this stp_search.js instead of custom.js. Otherwise to troubleshoot css and js can be confusing.
• You have a hook_menu that does not take you anywhere and looks like a bug to me, you should either fix that I remove it.
• Coder is showing a lot error, in the attached file you can see all the errors. Most of your error are due that your comments are not setup properly. I would recommend to read this article and use coder to auto-format your code, this would be a time saver.
• Pareview.sh is not able to scan your project properly because your project is compressed.
• I would recommend to add the hook_help, this can be very useful for site builders.

This isn't a bug report ;-)

Hi @kunal.maity.gmail,

You did good work. It will very useful for Large size of Projects. But I have a doubt. I have seen this custom_function() in your .module file. Am not sure where it is used. Kindly check this. If not necessary, please remove it . One more suggestion, Please check your code through coder module and http://pareview.sh/pareview/ tool. It will very helpful to enhance your coding styles.

Thanks,
Vimala.A

1) All your files should be in the root of your project.
Remove content_type_search_in_add_content_node_add__page.info file.

2) Incorrect hook comments throughout the file. Correct hook comment is: Implements hook_HOOK().

3) Add configure link in *.info file, so that a user can quickly reach at module configuration page from modules list.

4) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

5) /content_type/autocomplete page showing blank. Screenshot:-- http://prntscr.com/7sydo9

6) Install coder module, check your module with coder and fix those issues.

7) README.txt is missing in your module. Follows guidelines for in-project documentation and/or the README Template and create a file README.txt for your module.

Hi @kunal.maity.gmail,
Nice Work. Thank you for your response.

Hi there,

Reviewing your project I found some issues:
* When I cloned; I get a folder named 'stp_search-7.x'; and inside that folder; another named 'content_type_search'; I think the right is clone directly in content_type_search (without the upper folder).
* Since the repo contains the dev version of the project; you shouldn't add stable version number (without final .x) in .info file.
* I'm still seeing a lot of errors due to coding standards (mainly about comments, tabs instead of spaces, whitespaces and indentantion errors)
* You're adding your js and css files in hook_init to every page using drupal_add_js/drupal_add_css; it's the same effect than adding them in .info file; and adding them in .info file is recommended (cache and other stuff); so; you definitely should move them to .info file.
* You're using exit in some places; since Drupal has a wrapper around that function; you should change exit by drupal_exit().
* Your css file also have some indentation errors.
* Your js file also have tabs that should be changed by spaces; and maybe some indentation errors.

I totally recommend you to reading drupal coding standards (https://www.drupal.org/coding-standards);due to they are really important when working on Drupal.

Hi Kunal,
Thanks for contribution,

I come across with few issues:

* When i search any content type e.g. basic page, it does not show me the filtered content type but all content types kindly refer attached file.
* There are still lots of issues as per the drupal coding standards found on automated reviews http://pareview.sh/pareview/httpgitdrupalorgsandboxkunalmaitygmail2485283git. Kindly refer https://www.drupal.org/coding-standards doc.

Regards,
Rashid

Please click on the following link to check the automated PA review.

http://pareview.sh/pareview/httpgitdrupalorgsandboxkunalmaitygmail2485283git.

As you used below syntax to add js file

drupal_add_js("var jstring='" . addslashes($com_str) . "';", 'inline');
but it is recommended to use the following syntax to attach js/css files in the form.

$form['#attached']['css'] = array(
  drupal_get_path('module', 'ajax_example') . '/ajax_example.css',
);

$form['#attached']['js'] = array(
  drupal_get_path('module', 'ajax_example') . '/ajax_example.js',
);

Kindly refer below link and on method #3

https://www.drupal.org/node/756722.

Changing the status to "Needs Review", as the RTBC is to be done by the reviewers.

Kunal,
For the functionality point of view this module is working fine as i tested on my machine. But you see in JS file, lots html content is being used however you can create the template to render the form data and apply JS accordingly.
I would recommend to create the template to render form data and follow the best practice.

Regards,
Rashid