Properly pass langcode from contact message

Would tests be needed to clarify the problem?

On one hand "messsage" is a content entity but without storage
Otoh \Drupal\contact\Controller\ContactController::contactSitePage() should properly pass language to message form cunstructor

and after changing \Drupal\contact\MailHandler::sendMailMessages we can pass language to message builder
$recipient_langcode = $this->languageManager->getDefaultLanguage()->getId(); currently works

+++ b/core/modules/contact/src/Entity/Message.php
@@ -29,7 +29,8 @@
+ *     "langcode" = "langcode",

makes sense

#2533964: Langcode widget visibility settings from language.module are not applied consistently also adds the langcode key, but doesn't contain the other fixes. Will conflict with that.

Failed tests are shows that usage of message language somehow broken

Fail Other ConfigTranslation 346 Drupal\config_translation\Tests\Con
Value 'Thank you for your mail - fr' is equal to value 'Thank
you for your mail - en'.
Fail Other ConfigTranslation 346 Drupal\config_translation\Tests\Con
Value 'Thank you for your mail - ta' is equal to value 'Thank
you for your mail - en'.

Let's at least get #2533964: Langcode widget visibility settings from language.module are not applied consistently in soon so this needs to fix less :)

Let's get #2533964: Langcode widget visibility settings from language.module are not applied consistently in first.

@Michelle: you will definitely still be mentioned in the commit credits once/if this lands. So while the actual lines you wrote may not land, you will get the credit. I would say you should wait until #2533964: Langcode widget visibility settings from language.module are not applied consistently lands, which is why I marked this postponed, so that there is no duplication of work.

@Michelle my patch was just a test to make sure that contact is broken with passed language, actually I came here by reviewing current contact module issues after #2223967: Do not decode a contact message twice
I think the issue shows regression that mostly caused by that we used contact in 8.x dev as a playground for multilingual abilities of i18n

As #2533964: Langcode widget visibility settings from language.module are not applied consistently commited
this issue better re-focus on passing language to mail handler properly (#5) and add tests

re-scope and re-roll, cos langcode is here

There's a contrib that depends on it #2796335: Fix hard coded language on URL alias

Added tests, but not sure if implementation is correct... Please, check

Reroll

Tests already added

Added reroll of patch #25 on Drupal 9.4.x.

Added reroll of patch #25 on Drupal 9.5.x.

Fixing the issue Error: Call to undefined method Drupal\Tests\contact\Unit\MailHandlerTest::getMock() in the tests

Tests showing this failure:

There was 1 failure:

1) Drupal\Tests\config_translation\Functional\ConfigTranslationUiTest::testContactConfigEntityTranslation
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Thank you for your mail - en'
+'Thank you for your mail - fr'

Reroll the patch #43 with Drupal 10.1.x

Thanks @Ankit, I see a few coding standard issues in the patch #49

-class MailHandlerTest extends UnitTestCase {
+class MailHandlerTest extends UnitTestCase
+{

-  public function testInvalidRecipient() {
+  public function testInvalidRecipient()
+  {

Also could you please provide an interdiff which will make it easy to review your code.

Interdiff file attached .

Looks like there are some extra changes are there in patch #49, as there is around a 4kb difference in both patches.

Thanks for the interdiff. I have not reviewed for accuracy/readability. I was just scanning and noticed some minor formatting things:

1. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -31,10 +31,40 @@
   ++class MailHandlerTest extends UnitTestCase
   ++{
   

   Curly bracket needs to move back up

2. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -31,10 +31,40 @@
   ++{
   + ¶
   +   /**
   

   Extraneous space on blank line

3. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -31,10 +31,40 @@
   +-  protected function setUp(): void {
   ++  protected function setUp(): void
   ++  {
   

   Curly bracket needs to move back up

4. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -31,10 +31,40 @@
   +-  public function testInvalidRecipient() {
   ++  public function testInvalidRecipient()
   ++  {
   

   Curly bracket needs to move back up

5. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -58,7 +88,47 @@
   ++  public function testSendMailMessages(MessageInterface $message, AccountInterface $sender, $results)
   ++  {
   

   Curly bracket needs to move back up

6. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -58,7 +88,47 @@
   ++  public function getSendMailMessages()
   ++  {
   

   Curly bracket needs to move back up

7. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -58,7 +88,47 @@
   +-  protected function getMockSender($anonymous = TRUE, $mail_address = 'anonymous@drupal.org') {
   ++  protected function getMockSender($anonymous = TRUE, $mail_address = 'anonymous@drupal.org')
   ++  {
   

   Curly bracket needs to move back up

8. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -68,7 +138,17 @@
   +-  protected function getAnonymousMockMessage($recipients, $auto_reply, $copy_sender = FALSE) {
   ++  protected function getAnonymousMockMessage($recipients, $auto_reply, $copy_sender = FALSE)
   ++  {
   

   Curly bracket needs to move back up

9. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
   @@ -82,21 +162,43 @@
   +-  protected function getAuthenticatedMockMessage($copy_sender = FALSE) {
   ++  protected function getAuthenticatedMockMessage($copy_sender = FALSE)
   ++  {
   

   Curly bracket needs to move back up

10. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
    --  }
    +-  protected function getMockContactForm($recipients, $auto_reply) {
    ++  protected function getMockContactForm($recipients, $auto_reply)
    ++  {
    

    Curly bracket needs to move back up

11. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
    --  }
    +@@ -406,5 +443,4 @@ protected function getMockContactForm($recipients, $auto_reply) {
    + ¶
    +     return $contact_form;
    

    Extraneous space on blank line

12. +++ 2484959-49.patch	2022-10-12 12:59:31.794953100 +0530
    --  }
    +   }
    +-
    + }
    

    Blank line shouldn't be removed

Ah... these are all in the CI failure except for the extraneous spaces:

https://www.drupal.org/pift-ci-job/2497667

Fixed the coding standard issues and also tried to fix the other CI issues

Fixed 2nd Fail of #55

The Contact Module was approved for removal in #3476879: [Policy] Move Contact module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3520460: [meta] Tasks to deprecate the Contact module and the removal work in #3520466: [meta] Tasks to remove Contact module.

Contact will be moved to a contributed project after the Drupal 12.x branch is open.